I saw this on a blog today and thought it was an interesting feature.

Since this is the "anonymous comment notification" module that seems like a good feature.

CommentFileSizeAuthor
#33 288726_33_cn_node_subscribe.patch10.35 KBscor

Comments

PeterZ’s picture

I second the request for this. Many (registered) folks may want to subscribe without actually having to post a comment. The workaround is the one word postings we see in the drupal forums like "subscribing"; but it would be nice to avoid that workaround.

greggles’s picture

Version: 5.x-2.x-dev » 7.x-1.x-dev

My plan right now is to do one more release for 5.x and then do all development on 6.x. That will make it easier to work on issues like this since it requires changes to the DB. So...I'm changing the version to reflect that.

zilla’s picture

just wondering if this particular feature request could make use of this module for UUID: http://drupal.org/project/uuid (to alleviate some of the burden of you having to process each anonymous 'subscribe without comment' request easier? no idea if it makes sense, but seems interesting)

dave reid’s picture

I think this would be useful. I find myself hitting submit before realizing I wanted to subscribe to the comment or node.

Freso’s picture

subscribing

;)

greggles’s picture

My major problem with this idea is how to do it and keep from expanding the module enormously.

Some questions to consider:

1. So far the module works for anonymous users as well as authenticated. If we want this feature to work for anonymous we'd have to create additional UI and a new field in the table for an e-mail address.

Is this feature still useful if it's only for authenticated users?

2. I kind of assume that users should be able to subscribe to comments on a node that doesn't have any comments on it? That would require a real change to the table structure and moves this module further towards notifications/subscriptions territory. I don't think that makes sense...

We can get around #2 by associating the subscription with a comment ID value, which actually makes a lot of sense in the case of subscribing to a particular comment thread. However, in that case users wouldn't be able to subscribe to notifications until the first comment is posted on a node.

This might be a point where we have to draw the line and say "this light-weight module just adds the ability to get notifications if you post a comment."

greggles’s picture

One followup question to consider:

If we do generalize this module further to solve the problems in #6 where do we stop? If someone says "this module is great, but I'd like to be able to get notifications of all comments on nodes with a particular taxonomy term" is that unreasonable? What about "all comments by user X"? Where do we draw the line?

Artem’s picture

That is not supercritical, but definitely useful -> subscribing.

greggles’s picture

@artem - subscribing without addressing my concerns makes me think that this is not something appropriate to add to the module...

Artem’s picture

Well, I thought I addressed it in my comment - apparently I was not clear enough.
I do not think that this particular entry is critical or even important, it may very well be not valuable enough considering the amount of technical work needed.

So, I am not ready to "push" for this request. However, if somebody makes it happen, I will definitely use this functionality. It is of low, but clearly positive value for me.

elijah lynn’s picture

Subscribing

rokr’s picture

agharbeia’s picture

and when it's implemented, I hope it ( or something like it) is added here too :)

murokoma’s picture

+1

SeanBannister’s picture

sub

elijah lynn’s picture

I think this is a huge feature. Think of how much un-needed garbage content gets created everyday because people have to post something in order to subscribe.

By implementing this feature you would be doing a great service to the internet and its users!

greggles’s picture

@Elijah Lynn - this feature is somewhat in opposition to the purpose of this module. The goal with this module is to be an extremelly lightweight solution. If we start allowing subscriptions without commenting it requires rework to the database model and user interface in a way that will definitely increase the code. I'm not sure this module needs to be all-things-subscriptions to all people. We've already got modules which try to do that.

elijah lynn’s picture

Hi Greg,

I see the dilemma, where do we draw the line? This use case fits the title, "Comment Notify", perfectly. It notifies users, authenticated and anonymous, of new comments. If it weren't a code reworking, then from a user perspective I would say definitely, however, I am not a coder (yet) so maybe it isn't the best of ideas.

Maybe it would be better suited to be called "Comment Notify Lite."

Cheers,

Elijah

locomo’s picture

+1

subscribe

tsi’s picture

I know everybody wants to keep this module light and simple and out of the "notifications/subscriptions territory". Those modules can do a lot of things but they just can't do anonymous.
So if this is the price we have to pay for a complete anonymous notification solution I say +1.
I wish I could help with coding, I think this is an important feature, especially for d.o. but for my site also.
Watcher does half the job but don't give me the checkbox for those who do post a comment.
Personally I would love to see a flag/rules feature to (automatically?) flag nodes I participated on and (optionally) flag nodes I'm interested on - without my participation - so I will be notified when new comments are published.

Anonymous’s picture

IANAH, but wouldn't it be possible to use the status column in the comments table, by inventing a new constant in the COMMENT_PUBLISHED (0/false) , COMMENT_NOT_PUBLISHED (1/true) family such as COMMENT_HIDDEN with the defined value of 2/true. Furthermore, sites requiring this feature should of course use COMMENT_ANONYMOUS_MAY_CONTACT or COMMENT_ANONYMOUS_MUST_CONTACT. When anonymous signs up for notifications using some new button, a new comment with no body or subject is actually created, that isn't ever rendered or even presented for moderation. It's just a placeholder for the email address and name that are in turn stored wherever contact information related to COMMENT_ANONYMOUS_MAY_CONTACT or COMMENT_ANONYMOUS_MUST_CONTACT is currently stored... so this module can look up the email address from it by looking for COMMENT_HIDDEN.

mlncn’s picture

A similar feature, allowing users to subscribe to alerts from every comment on every thread sitewide, might also fit in here. Granted, that's going the way of bigger modules like Subscriptions and Notifications. In any case, subscribing.

rahim123’s picture

+1
This is an important feature. Otherwise people fill the forum with "Subscribe" or "Unsubscribe" posts.

coderintherye’s picture

This might be a point where we have to draw the line and say "this light-weight module just adds the ability to get notifications if you post a comment."

@greggles So did you draw the line there, and if so, are you working on adding that particular feature (Subscribe to notifications of further comments on a node that has already been commented on)? I'd be glad to help review a patch if someone wants to put one together.

greggles’s picture

I think there's probably a way to keep this lightweight and still let people subscribe without a comment. I think nobody has wanted this enough to work on it (or sponsor it) is the biggest problem.

klonos’s picture

irony... subscribing ;)

tsvenson’s picture

Being able to anonymously subscribe to comments without having to also make a comment would be an excellent addition to this module.

The cost of the additional code/complexity definitely outweighs users having to create a "subscribe" comment as it is now.

TimelessDomain’s picture

FLAG-Based Solution Proposal: using flag module to either subscribe to all comments on a node (Node Flag) OR subscribe to all replies to a comment (Comment Flag) would be great. This would be done by setting up actions for comment notify that can be applied with flag module & other modules (such as rules).

mikeybusiness’s picture

Before I even read #28 I was thinking the same thing. With exposure to flags and rules, it seems like you could do a lot by letting those modules do the logistics without having to introduce a lot of bloat. For that matter could it be an additional sub module? That way people that like to keep things simple could just not use or not turn it on.

klonos’s picture

Title: allow users to subscribe without posting a comment » allow users to subscribe without posting a comment + allow users to unsubscribe

...minor title edit to clarify that we intent to implement a means of unsubscribing as well.

greggles’s picture

@klonos, I'm not sure what you mean. There is already a means to unsubscribe which is include din the default e-mail template.

klonos’s picture

Title: allow users to subscribe without posting a comment + allow users to unsubscribe » Allow users to subscribe without posting a comment

Sorry Greg/people. I was under the impression I was posting in this core issue: #34496: [meta] Add Flag module to allow users to subscribe/unsubscribe without posting a comment

Wrong project queue - my bad :|

scor’s picture

Status: Active » Needs work
StatusFileSize
new10.35 KB

This patch creates a new table comment_notify_node to store the association between users and nodes they subscribed to. A link to subscribe is also added the node links. this patch is very much WIP.

omnyx’s picture

As answer to #25, maybe we should look in something like this. I'd gladly pitch in to get this functionality.

/subscribing

greggles’s picture

@omnyx - it seems like scor is working on this. Perhaps you could contact him and offer to pay directly? No reason to involve a third party.

I approve of this basic approach and based on my previous interactions with scor would be willing to review and accept a patch that he creates for this.

Ela’s picture

subscribing :)

reysharks’s picture

Subscribe!

coderintherye’s picture

#38 You no longer have to comment here to subscribe, you can use the "Follow" button in the top right

zilla’s picture

any idea how drupal.org is specifically doing this?

coderintherye’s picture

klonos’s picture

...it's achieved by using the Project, Project issue tracking & Flag modules and some custom code I guess.

IWasBornToWin’s picture

Was patch from #33 ever committed? Can users now subscribe without commenting?

scor’s picture

The schema in #33 needs to be updated to have both nid and uid as primary key. I don't have time to update the patch, but here is the diff for comment_notify.install:

@@ -112,7 +112,7 @@ function comment_notify_schema() {
         'default' => 0,
         'disp-width' => '11'),
     ),
-    'primary key' => array('nid'),
+    'primary key' => array('nid', 'uid'),
     'indexes' => array(
       'notify_hash' => array('notify_hash')),
   );

I won't have time to work on this issue further so someone else should push it forward.

Anonymous’s picture

You could do his with Flag and Rules modules, or if you don't want to muck around, the Node Notify module uses a subscribe/unsubscribe link to let you follow comments.