Forms API reference guide is missing password_confirm as a possible #type value -
http://api.drupal.org/api/file/developer/topics/forms_api_reference.html...
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | drupal-290074-1067116.patch.txt | 15.03 KB | JuliaKM |
| #4 | drupal-290074-1067116.patch | 15.03 KB | JuliaKM |
Comments
Comment #1
Noyz commentedChanged the component to reflect the new component categorization. See http://drupal.org/node/301443
Comment #2
add1sun commentedMoving to queue for API docs.
Comment #3
JuliaKM commentedComment #4
JuliaKM commentedThis is a first pass at adding the password_confirm type. Code needs review for accuracy.
Comment #6
JuliaKM commentedRunning into the same problem as jeffschuler here. The patch fails testing because the API docs are not part of Drupal core.
The patch is re-attached as .txt file.
Comment #7
JuliaKM commentedComment #8
kwinters commentedBased on the last couple comments, I believe this is misclassified as Needs Work. Changed to Needs Review so it will get some attention (the documentation is still missing from the api site).
Comment #9
jhodgdonThis patch needs a little work:
- I think the password confirm element needs a section in the "Default Values" section.
- The usage example has #type->"password", which is probably incorrect.
- "password confirm" has not been added to the #type section. There are a couple of other missing types in that section, too, so if you are going to edit that section, you might consider making sure "image_button" and other types that are in the two tables at the top of the page are included.
- I think the correct type is "password_confirm" not "password confirm".
Comment #10
jhodgdonAdditional missing elements:
tableselect (Drupal 7)
token (Drupal 6 and Drupal 7)
vertical_tabs (Drupal 7)
Comment #11
jhodgdonI've added password_confirm to the form API docs for Drupal 6 and Drupal 7. The other elements listed in #10 still need to be added, so I'm leaving this issue open for the moment. Commits: http://drupal.org/cvs?commit=232760 and http://drupal.org/cvs?commit=232758
Comment #12
jhodgdonThe token element is now added to the Drupal 6 doc - commit: http://drupal.org/cvs?commit=234226
Comment #13
jhodgdonThe token, tableselect, and vertical_tabs elements are now added to Drupal 7 doc - commit: http://drupal.org/cvs?commit=234252
Comment #14
kwinters commentedhttp://api.drupal.org/api/file/developer/topics/forms_api_reference.html... doesn't list password_confirm as a possible value, but otherwise looks good. It's in the chart though.
Comment #15
jhodgdonI'll fix that tomorrow. Thanks for pointint it out! That doc is so enormously long and complex... I'm sure that's not the only oversight...
Comment #16
jhodgdonFixed in D6 and D7 - there were other types missing too -- thanks again kwinters for pointing this out!
Commits http://drupal.org/cvs?commit=235928 and http://drupal.org/cvs?commit=235930 -- should show up on api.drupal.org within 24 hours or so.
Comment #17
jhodgdon