Forms API reference guide is missing password_confirm as a possible #type value

nonsie - August 1, 2008 - 17:00
Project:Drupal
Version:7.x-dev
Component:documentation
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Forms API reference guide is missing password_confirm as a possible #type value -
http://api.drupal.org/api/file/developer/topics/forms_api_reference.html...

#1

Noyz - August 31, 2008 - 10:10
Component:Developer Guide» Correction/Clarification

Changed the component to reflect the new component categorization. See http://drupal.org/node/301443

#2

add1sun - October 19, 2008 - 22:42
Project:Documentation» Drupal
Version:<none>» 7.x-dev
Component:Correction/Clarification» documentation

Moving to queue for API docs.

#3

JuliaKM - March 7, 2009 - 18:18
Assigned to:Anonymous» JuliaKM

#4

JuliaKM - March 7, 2009 - 19:03
Status:active» needs review

This is a first pass at adding the password_confirm type. Code needs review for accuracy.

AttachmentSize
drupal-290074-1067116.patch 15.03 KB
Testbed results
drupal-290074-1067116.patchfailedFailed: Failed to apply patch. Detailed results

#5

System Message - March 7, 2009 - 19:20
Status:needs review» needs work

The last submitted patch failed testing.

#6

JuliaKM - March 7, 2009 - 19:58

Running into the same problem as jeffschuler here. The patch fails testing because the API docs are not part of Drupal core.

The patch is re-attached as .txt file.

AttachmentSize
drupal-290074-1067116.patch.txt 15.03 KB

#7

JuliaKM - March 7, 2009 - 21:30
Assigned to:JuliaKM» Anonymous

#8

kwinters - June 9, 2009 - 16:44
Status:needs work» needs review

Based on the last couple comments, I believe this is misclassified as Needs Work. Changed to Needs Review so it will get some attention (the documentation is still missing from the api site).

#9

jhodgdon - June 17, 2009 - 17:20
Status:needs review» needs work

This patch needs a little work:

- I think the password confirm element needs a section in the "Default Values" section.
- The usage example has #type->"password", which is probably incorrect.
- "password confirm" has not been added to the #type section. There are a couple of other missing types in that section, too, so if you are going to edit that section, you might consider making sure "image_button" and other types that are in the two tables at the top of the page are included.
- I think the correct type is "password_confirm" not "password confirm".

#10

jhodgdon - July 2, 2009 - 17:16

Additional missing elements:
tableselect (Drupal 7)
token (Drupal 6 and Drupal 7)
vertical_tabs (Drupal 7)

#11

jhodgdon - July 2, 2009 - 19:18
Status:needs work» active

I've added password_confirm to the form API docs for Drupal 6 and Drupal 7. The other elements listed in #10 still need to be added, so I'm leaving this issue open for the moment. Commits: http://drupal.org/cvs?commit=232760 and http://drupal.org/cvs?commit=232758

#12

jhodgdon - July 6, 2009 - 20:34

The token element is now added to the Drupal 6 doc - commit: http://drupal.org/cvs?commit=234226

#13

jhodgdon - July 6, 2009 - 21:20
Status:active» fixed

The token, tableselect, and vertical_tabs elements are now added to Drupal 7 doc - commit: http://drupal.org/cvs?commit=234252

#14

kwinters - July 9, 2009 - 22:00

http://api.drupal.org/api/file/developer/topics/forms_api_reference.html... doesn't list password_confirm as a possible value, but otherwise looks good. It's in the chart though.

#15

jhodgdon - July 10, 2009 - 00:55
Status:fixed» needs work

I'll fix that tomorrow. Thanks for pointint it out! That doc is so enormously long and complex... I'm sure that's not the only oversight...

#16

jhodgdon - July 10, 2009 - 21:43

Fixed in D6 and D7 - there were other types missing too -- thanks again kwinters for pointing this out!

Commits http://drupal.org/cvs?commit=235928 and http://drupal.org/cvs?commit=235930 -- should show up on api.drupal.org within 24 hours or so.

#17

jhodgdon - July 10, 2009 - 21:43
Status:needs work» fixed

#18

System Message - July 24, 2009 - 21:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.