Needs work
Project:
Project
Version:
6.x-1.x-dev
Component:
Projects
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Aug 2008 at 20:39 UTC
Updated:
16 Jan 2009 at 07:39 UTC
Jump to comment: Most recent file
Patch attached changes "release/project_release.js" functions to be included with Drupal.behaviors and no more doc.ready logic. Untested, needs review.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | D6_project_Drupal_behaviors_project_release_2009011301.patch | 975 bytes | hass |
| Project_D6_project_releaseJS_1.patch | 888 bytes | hass |
Comments
Comment #1
hass commentedPatches apply are against aclight's SYN.
Comment #2
hass commentedComment #3
aclight commentedAs per http://drupal.org/node/114774#javascript-behaviors I believe that something needs to be changed near where we use
.each.The upgrade docs give the following example:
Old code:
New code:
Comment #4
hass commentedI've stolen this from OG... and therefore it seems to be ok. We are not using each in the old code and therefore we don't use it in new code...
Comment #5
hass commentedhttp://raincitystudios.com/blogs-and-pods/katherine-bailey/the-lowdown-j...
http://api.drupal.org/api/file/developer/topics/javascript_startup_guide...
Comment #6
hass commentedI've also checked the same change in Google Analytics 6.x-2.x and it seems working well.
Comment #7
dwwComment #8
hass commentedPatch against CVS without local windows paths for easier patching. No changes.
Comment #9
dwwCommitted #8 to HEAD since that part is fine and working. However, project_release.js does use .each(), and it seems like what aclight pointed out in #3 is still applicable.
Comment #10
hass commentedI've only upgraded the outdated
$(document).ready(Drupal.projectReleaseAutoAttach);on doc ready to the new logic. As we are only changing one element we don't need to "each" something else... !?