Closed (fixed)
Project:
Conditional Fields
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Aug 2008 at 17:02 UTC
Updated:
30 Apr 2012 at 17:28 UTC
Jump to comment: Most recent file
Comments
Comment #1
threexk commentedThis issue was identified in http://drupal.org/node/269145 and I wrote a patch, but apparently my patch was incomplete. On that line you mention, the ampersand just needs to be removed. I'll post a new patch shortly.
I'm changing the priority on this bug to normal because the module still operates properly with the warning.
Comment #2
threexk commentedComment #3
peterpoe commentedComment #4
threexk commentedpeterpoe: This issue is indeed a duplicate of http://drupal.org/node/269145, but by my mistake the patch for that issue only fixed one out of two warnings. That's why this issue was created. This line still needs its ampersand removed:
conditional_fields_set_required_for_render(&$item);
Can you make this change directly, or should I make a new patch?
Comment #5
peterpoe commentedRequired fields in d5 are still buggy (see also #292044: Required fields within conditional groups not indicated as required). In d6 after many changes (in d6 the function conditional_fields_set_required_for_render does not even exist!) they work correctly, but the fixes have not been yet backported to d5. Will backport the fixes from d6 as soon as d6 is ready for release (it should not take long), but if you want to help with this you are welcome.
Comment #6
abramo commentedJust a reminder that this issue is still alive and well :)
Comment #7
abramo commentedComment #8
threexk commentedabramo: In the meantime until the fix gets backported, you can just remove the ampersand in the two instances of the following text in conditional_fields.module:
conditional_fields_set_required_for_render(&$item);
Comment #9
abramo commentedmany thanks - I just mentioned this as a mere reminder ;-)
Comment #10
peterpoe commentedPostponing like all 5.x-1.x-dev issues already fixed in v6.
Comment #11
peterpoe commentedClosing all 5.x issues.