can't replace default logo [#29221]

hello and thanks-

thought i would report in on a bug i found-
no matter what i try- i simply can not get
any new images uploaded to replace the default logo.

if i toggle it off-
and then go to upload- it (the default drupal logo)-
comes back as active and displayed.

basically i am experiencing almost the exact same symptoms
as reported fixed in this post:

http://drupal.org/node/26822
Logo uploads are broken

i am using a 'stock' (default) and fresh install of
the tarball posted for drupal 4.6.3 and i am getting these errors
and not able to do anything except toggle off the drupal logo-
across all themes or any one of them- nothing works here like it should.

i tried taking a look at the code-
and the patch-

and the files affected maybe but i got a little lost.
should be easy to spot for steven or drumm what might have happened here.

thanks again- for drupal is the bomb-
just thought you would appreciate knowingthis glitch looks like it made it to the tarball somehow...?

thanks-
vincent

Comments

Comment #1

Uwe Hermann CreditAttribution: Uwe Hermann commented 26 August 2005 at 23:28

Version:

4.6.0

» 4.6.3

Comment #2

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles commented 8 January 2006 at 19:15

Version:

4.6.3

» 4.6.5

I found this to still be a problem in 4.6.5.

I could not repeat it in CVS-Head.

Comment #3

Zen CreditAttribution: Zen commented 3 February 2006 at 15:59

Priority:

Critical

» Normal

Comment #4

liquidcms CreditAttribution: liquidcms commented 20 February 2006 at 21:58

Title:

logo uploads still broken...? can't replace default logo with new drupal 4.6.3 tar ball?

» this ever get fixed

I have 4.6.5 and my permissions are set for everyone ot access to drupal/files folder

but when ever i try to upload log it just flips back to default box checked.

Comment #5

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 20 February 2006 at 22:47

Title:

this ever get fixed

» can't replace default logo

Just a note, issues don't work the same as forum posts; when you change the title for your comment it changes the title for the entire issue. So please make sure it retains information that helps people understand what the issue is about. :)

Comment #6

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles commented 21 February 2006 at 00:03

The workaround for this (if you have site access) is simply to go into the theme/
/ directory and replace the logo.png (or similar) file that is in that location with your logo. This is not super convenient, but it works.

Comment #7

mgifford

he/him

English

CreditAttribution: mgifford commented 7 March 2006 at 06:02

Ok, there still seem to be some bugs with 4.7 on this.. but more importantly, what do we do with 4.6.5 installs where this is still a problem?

If the box is going to the there it should work. Otherwise it makes the whole system look bad (as replacing the logo is one of the first things folks will try to do).

Mike

Comment #8

mgifford

he/him

English

CreditAttribution: mgifford commented 7 March 2006 at 06:41

Status:

Active

» Needs review

Bit tired to actually put this into a patch tonight, but if you insert this on line 647 of the system.module it should do the trick.

   if(empty($settings['logo_path'])) {
     $base_logo_path = variable_get('file_directory_path', 'files') . '/' . $key. '_logo.';
     if (is_file($base_logo_path . 'jpg'))
        $settings['logo_path'] = $base_logo_path . 'jpg';
     elseif(is_file($base_logo_path . 'gif'))
       $settings['logo_path'] = $base_logo_path . 'gif';
     elseif(is_file($base_logo_path . 'png'))
       $settings['logo_path'] = $base_logo_path . 'png';
   }

That would be right before the Path to custom logo is called.

Would be better to automate this further. Realize the code above is a bit bulky.. Just wanting to propose a solution.

Mike