Closed (fixed)
Project:
Project
Component:
Issues
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Aug 2005 at 06:26 UTC
Updated:
6 Oct 2005 at 17:20 UTC
Jump to comment: Most recent file
I just ran this search on drupal.org:
http://drupal.org/project/issues/drupal?page=1&projects=3060&text=forum&...
Roughly: searching for issues of any kind in forum.module with the word 'forum' in them, active->fixed.
The search results appeared as many times as there were comments on the node in question. This is odd.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | project-duplicate-search-results.patch | 3.46 KB | nedjo |
| #3 | project_4.patch | 3.7 KB | nedjo |
Comments
Comment #1
chx commentedI suspect this has to do something with the fixed (aka. changed) node_get_module_name. As project is breaking the API with its node names (node names are prefixed with modulename and a dash per drupaldocs.org), said function returned the whole node type not just 'project'. Now it returns 'project' all the time -- the old function relied on the dash, my rewrite of said function does not rely on such a convention. Maybe this will help someone who will work on fixing this.
Comment #2
Tobias Maier commented*bump*
please fix it!!
thanks
Comment #3
nedjoNot sure why this is happening, I haven't looked closely enough at the code. Would simply adding some DISTINCTs to the queries at least provide a temporary fix, see attached (untested).
Comment #4
rgladwell commentedComment #5
nedjoThis patch is tested and eliminates duplicate search results (at least on my local project module install). It also includes needed updates to make issues revision-aware.
Comment #6
dries commentedCode looks good. Is that $sql safe for SQL injection attacks? If so, feel free to commit.
Comment #7
nedjoIt doesn't introduce any new input parameters, so yes.
Applied.
Comment #8
(not verified) commented