Comments

dww’s picture

#137609: Theme function for signup_build_signup_data is now a blocker for 5.x-2.5 (since there are a few bugs that would solve).

#132142: Add setting to use site-wide date formatting strings instead of our own weird setting would be good, just since it's a minor bug that's been around so long and would be easy to fix. ;)

#295542: Add user tokens to those able to be substituted in Signup emails would be nice if we can resolve the problems, but not a blocker (especially since it's a new feature).

dww’s picture

Status: Postponed » Needs review

Ok, this no longer officially blocked. ;)

a) If anyone can test the latest HEAD (or the 5.x-2.x-dev tarball -- just make sure it includes signup.settings.js and you'll know you've got the latest code), and see if they find anything funky, please do. If you find a bug, feel free to open an issue for it. Either way, please report back here.

b) The only issues I'm even considering before the 5.x-2.5 release at this point are:
#295542: Add user tokens to those able to be substituted in Signup emails
#47913-6: More themeability
#86462: add backend support for cck date fields

I'd love feedback from anyone who cares on if we should just ship now and target all three of those for 5.x-2.6, or if we should hold up 5.x-2.5 any longer. I'm strongly leaning towards shipping 5.x-2.5 now and putting those off, but I'm open to discuss it. ;)

Kind souls who wish to test DRUPAL-5 for the 5.x-1.1 release are welcome, too...

Thanks!
-Derek

dww’s picture

Status: Needs review » Postponed

After more thought and work, the only issues holding up 5.x-2.5 are:
#320845: Page / Block option is a little unclear
#321463: "Please login or register" printed even if all auth users don't have signup perms
Both have patches that could use a little more review.

I'm definitely going to wait for the CCK patch (#86462: add backend support for cck date fields) until 5.x-2.6. In fact, that might be about the only issue that 5.x-2.6 is for. ;)

dww’s picture

shanefjordan’s picture

I've been testing the 2.x-dev version and everything looks to be working fine. How close are we to the release for 5.x-2.5? I need to make a switch on our website and would like to run the new release and then move towards the 2.6 version with the cck date support (even though i'll probably run 2.5 with the current cck date patch thats available).

dww’s picture

Re: "How close are we to the release for 5.x-2.5?"

Extremely. We just need deviantintegral to take a final look at #320845: Page / Block option is a little unclear (which is probably RTBC). Once he agrees, I'll commit that, then tag/release. Entirely possible that'll all happen later tonight (I only have a few minutes right now, and deviantintegral is in the middle of other stuff, too).

Everything else is going into 5.x-2.6 or later.

dww’s picture

Re: "How close are we to the release for 5.x-2.5?"

Extremely. We just need deviantintegral to take a final look at #320845: Page / Block option is a little unclear (which is probably RTBC). I wouldn't mind a 2nd opinion on #322528: Change description of signup_available_signups view, too, but that's not as important. Once those are RTBC, I'll commit, then tag/release. Entirely possible that'll all happen later tonight (I only have a few minutes right now, and deviantintegral is in the middle of other stuff, too).

Everything else is going into 5.x-2.6 or later.

dww’s picture

Status: Postponed » Needs review

Ok, everything I was planning to get done for this has been completed.

I just did some more testing and discovered #132142-11: Add setting to use site-wide date formatting strings instead of our own weird setting and fixed it with http://drupal.org/cvs?commit=147140

Any other testing would be welcome!

Thanks,
-Derek

stBorchert’s picture

Status: Needs review » Reviewed & tested by the community

Since noone else seems to test this (:-)) I've done some small testing.
Result: no errors or things to improve (in this release) found.

 Stefan

dww’s picture

Version: 5.x-2.x-dev » 5.x-2.5
Status: Reviewed & tested by the community » Fixed
shanefjordan’s picture

Thank you!!!!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.