The attached patch fixes two things in the current Coding Standards document:

  • The link which should refer to the mailing list thread discussing the removal of the ?> tag at the end of modules and other PHP files is updated. This was no longer correct and resulted in a 404.
  • The definition studlyCaps was incorrect. StudlyCaps means that random letters in a word can be capitalized. The correct term should be lowerCamelCase.
CommentFileSizeAuthor
cs.patch1.13 KBj.somers

Comments

j.somers’s picture

j.somers commented
Status: Needs review » Active
Noyz’s picture

Noyz commented
Component: Coding standards » Correction/Clarification
Noyz’s picture

Noyz commented

Changed the component to reflect the new component categorization. See http://drupal.org/node/301443

j.somers’s picture

j.somers commented
Status: Active » Needs review

I was advised to change the status back to 'patch (code needs review)' so someone could review the patch and commit it, if OK.

gpk’s picture

gpk commented
Title: Fixed mailing list URL and incorrect capitalisation term. » A couple of fixes need on coding standards page

I think this actually just needs someone with the relevant privileges to edit the http://drupal.org/coding-standards page.

To make it really easy for someone to do that, I'll re-iterate what needs doing here:

1. In the section PHP Code tags, the link for the "no ?> needed at the end of modules" discussion needs changing from http://lists.drupal.org/archives/drupal-devel/2005-08/msg00648.html to http://lists.drupal.org/pipermail/development/2005-August/008043.html

2. In the Naming Conventions section, subheading Class Names, change

studlyCaps

to
lowerCamelCase

3. Then comment http://drupal.org/coding-standards#comment-1004329 can be deleted.

Also changed title of this issue to try to attract attention!

add1sun’s picture

add1sun commented

coolio, thanks for the breakdown. currently the coding standards page is generated from CVS, so you can either create a patch for it, or if you have a CVS account you can commit the changes yourself. The page itself needs to be manually updated from the server, so the changes won't appear until we get infra to do that. :-/

I've made an issue to make this a regular handbook page as well: #306569: Make coding standards a regular book page

gpk’s picture

gpk commented
Status: Needs review » Reviewed & tested by the community

Ahhh, my fault for clouding the issue then. The patch is aready there in the original post!

Please treat #5 as a verbose description of what the patch does then!

Patch applies OK, all looks good, hence RTBC.

junedkazi’s picture

junedkazi commented
Priority: Normal » Critical
Status: Reviewed & tested by the community » Active

no ?> needed at the end of modules link under PHP Code Tags leads to a page not found .
Is the patch mentioned above applied to the page or not ?

Thanks

Juned Kazi

junedkazi’s picture

junedkazi commented

RFC 2606 link under Example URLs also leads to a page not found

Thanks

Juned Kazi

add1sun’s picture

add1sun commented
Status: Active » Fixed

Fixed the RFC and PHP tag links. The studlyCaps issue will get addressed when the #260220: OOP standards get redone here shortly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

gpk’s picture

gpk commented
Status: Closed (fixed) » Fixed

Have fixed the studlyCaps issue which is generating comment on the page itself, obviously OOP standards need a bit more info, only just seen the link above at #10.

Also noting here that the link to the PHP tag link was fixed (#10) by removing it; the discussion referenced is of little import to the coding standards page itself.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.