Closed (won't fix)
Project:
Simplenews
Version:
5.x-1.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Aug 2008 at 19:26 UTC
Updated:
5 May 2009 at 11:16 UTC
function simplenews_confirm_add_form_submit() is called for all anonymous users after an anonymous user signs up, for a duration up until another anonymous user signs up.
Meaning, the last lucky user to sign up has his or her email plastered at the top of the home page for days for all the world and robots to see.
I simply commented it out the drupal_set_message() call until a real fix is in. ( maybe a session test? )
It looks like similar will happen when someone has the audacity to "anonymously" unsubscribe.
Here is a diff of my quick and dirty fix:
--- simplenews.module.orig 2008-08-11 18:47:02.664911803 +0000
+++ simplenews.module 2008-08-11 19:01:39.496903912 +0000
@@ -2637,7 +2637,9 @@
*/
function simplenews_confirm_add_form_submit($form_id, $form_values) {
simplenews_subscribe_user($form_values['mail'], $form_values['newsletter']->tid, FALSE);
- drupal_set_message(t('%user was successfully added to the %newsletter subscription list.', array('%user' => $form_values['mail'], '%newsletter' => $form_values['newsletter']->name)));
+ /* dan@garthwaite.org 20080811 Removed until debugged - anonymous users seeing last users confirmation
+ drupal_set_message(t('%user was successfully added to the %newsletter subscription list.', array('%user' => $form_values['mail'], '%newsletter' => $form_values['newsletter']->name)));
+ */
return '';
}
Comments
Comment #1
DanGarthwaite commentedNOTE:
Caching was set to 'normal'. I had to disable it to make it 'go away' even after commenting out the drupal_set_message(). Maybe this is a caching bug?
Comment #2
sutharsan commentedThis is a core thing and not for simplenews to solve.
A solutions is available in the current Drupal 6. See http://drupal.org/node/168909 (#28)
Comment #3
DanGarthwaite commentedThis error just emerged for me again on a new site, new drupal, new simpletest.
Comment #4
Andrew Jamieson commentedI am having the same problem. Drupal 5 installation. This is a pretty big bug guys? Any development here?