Port tracker2 to 6.x
andypost - August 11, 2008 - 23:48
| Project: | Tracker 2 |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | Jody Lynn |
| Status: | closed |
| Issue tags: | drupal.org upgrade |
Description
Are there plans to port it?
#1
subscribing
#2
+1
#3
+1
#4
Here's an at least partly working, minimum effort port...
I'm using the tracker2 tables to do a simplified query of my own, so I have not spent much time checking the user-interface parts. Known working:
1. Install, albeit old-style (not updated to use schema API)
2. Cron job
3. Update on add new content
4. Admin interface
5. /tracker page
6. /tracker user page
Not for deployment! Just dumping what I have. Maybe I'll finish it sometime... maybe not. If anyone else wants to brush it up, please do!
#5
#6
Re-rolled patch from HEAD and updated to use Schema API. To apply:
cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -d tracker2 contributions/modules/tracker2wget -O - http://drupal.org/files/issues/tracker2.CVS-HEAD-to-6.x-dev.diff | patch -p0 -d tracker2
#7
Tracker2 is used on drupal.org as well, so this upgrade is important for the mothership! Keep up the work!
#8
so how is it working on the mothership and not released to us??
is drupal.org on d6?
#9
Here's the error I got:
user warning: Can't DROP 'tracker'; check that column/key exists query: ALTER TABLE comments DROP INDEX tracker in /mysite/includes/database.mysql-common.inc on line 448.
#10
@chasz - No, that was his point. This is one of the things needed to move to 6.x.
Michelle
#11
Subscribing...
#12
fixes the issues and some coding style of the patch of #6
added some tests, not all passes yet :(
#13
I am currently finishing this port starting with the patch in comment 12.
Marking critical because it is needed for Drupal.org upgrade: http://groups.drupal.org/node/17294
#14
do you know another module which could be ported for do d6?
#15
I went through the module and refactored, cleaning things up:
Moved functions into tracker2.admin.inc and tracker2.pages.inc,
added a themeable function for the tracker2 output,
upgraded functions to D6 where not done,
added some comments for functions,
simplified readability of code where possible.
I have some TODOs in this patch which are outstanding work needed. Also needs a lot of work on the tests.
(I will continue work on the TODOs etc but posting work in progress for collaboration.)
@David Strauss: Could you create a D6 branch to facilitate this work and/or add me as a maintainer? Thanks.
#16
And here's the patch...
#17
Same as above but I also added a setting for 'nodes per page' so that admins can customize from the default of 25 items shown per page on the tracker.
#18
I added validation to the admin settings form. Full patch attached (all patches are against HEAD).
#19
#20
@dereine: watch out for the "drupal.org upgrade" tag, which I am starting to add to relevant issues
#21
for other people, here is a direct link to it : http://drupal.org/taxonomy/term/346
#22
Subscribe
#23
Removed code related to node bulk operations (node operations in D6 run through node_save so no special code is needed) and removed TODOs after further testing.
Patch needs review including test of upgrade from D5 version. dereine is writing simpletests.
#24
I applied the patch, committed it to HEAD, and branched as DRUPAL-6--1. A nightly dev snapshot will be available shortly.
#25
Cool. Let's post ongoing development and bug fixes into separate issues then.
#26
Automatically closed -- issue fixed for 2 weeks with no activity.