Download & Extend

Port tracker2 to 6.x

Project:Tracker 2
Version:5.x-1.x-dev
Component:Code
Category:task
Priority:critical
Assigned:Jody Lynn
Status:closed (fixed)
Issue tags:drupal.org upgrade

Issue Summary

Are there plans to port it?

Comments

#1

subscribing

#2

+1

#3

+1

#4

Here's an at least partly working, minimum effort port...
I'm using the tracker2 tables to do a simplified query of my own, so I have not spent much time checking the user-interface parts. Known working:

1. Install, albeit old-style (not updated to use schema API)
2. Cron job
3. Update on add new content
4. Admin interface
5. /tracker page
6. /tracker user page

Not for deployment! Just dumping what I have. Maybe I'll finish it sometime... maybe not. If anyone else wants to brush it up, please do!

AttachmentSize
tracker2-d6-0.0.patch 6.35 KB

#5

Title:Port 6.x» Port tracker2 to 6.x
Category:support request» task
Status:postponed (maintainer needs more info)» needs work

#6

Re-rolled patch from HEAD and updated to use Schema API. To apply:

cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -d tracker2 contributions/modules/tracker2
wget -O - http://drupal.org/files/issues/tracker2.CVS-HEAD-to-6.x-dev.diff | patch -p0 -d tracker2
AttachmentSize
tracker2.CVS-HEAD-to-6.x-dev.diff 11.6 KB

#7

Tracker2 is used on drupal.org as well, so this upgrade is important for the mothership! Keep up the work!

#8

so how is it working on the mothership and not released to us??

is drupal.org on d6?

#9

Here's the error I got:

user warning: Can't DROP 'tracker'; check that column/key exists query: ALTER TABLE comments DROP INDEX tracker in /mysite/includes/database.mysql-common.inc on line 448.

#10

@chasz - No, that was his point. This is one of the things needed to move to 6.x.

Michelle

#11

Subscribing...

#12

Status:needs work» needs review

fixes the issues and some coding style of the patch of #6

added some tests, not all passes yet :(

AttachmentSize
tracker2_port_d6.patch 20.4 KB

#13

Priority:normal» critical
Assigned to:Anonymous» Jody Lynn
Status:needs review» needs work

I am currently finishing this port starting with the patch in comment 12.
Marking critical because it is needed for Drupal.org upgrade: http://groups.drupal.org/node/17294

#14

do you know another module which could be ported for do d6?

#15

I went through the module and refactored, cleaning things up:

Moved functions into tracker2.admin.inc and tracker2.pages.inc,
added a themeable function for the tracker2 output,
upgraded functions to D6 where not done,
added some comments for functions,
simplified readability of code where possible.

I have some TODOs in this patch which are outstanding work needed. Also needs a lot of work on the tests.

(I will continue work on the TODOs etc but posting work in progress for collaboration.)

@David Strauss: Could you create a D6 branch to facilitate this work and/or add me as a maintainer? Thanks.

#16

And here's the patch...

AttachmentSize
trackerport.patch 34.19 KB

#17

Same as above but I also added a setting for 'nodes per page' so that admins can customize from the default of 25 items shown per page on the tracker.

AttachmentSize
trackerport2.patch 34.71 KB

#18

I added validation to the admin settings form. Full patch attached (all patches are against HEAD).

AttachmentSize
trackerport3.patch 35.34 KB

#19

#20

@dereine: watch out for the "drupal.org upgrade" tag, which I am starting to add to relevant issues

#21

for other people, here is a direct link to it : http://drupal.org/taxonomy/term/346

#22

Subscribe

#23

Status:needs work» needs review

Removed code related to node bulk operations (node operations in D6 run through node_save so no special code is needed) and removed TODOs after further testing.

Patch needs review including test of upgrade from D5 version. dereine is writing simpletests.

AttachmentSize
trackerport4.patch 35.2 KB

#24

I applied the patch, committed it to HEAD, and branched as DRUPAL-6--1. A nightly dev snapshot will be available shortly.

#25

Status:needs review» fixed

Cool. Let's post ongoing development and bug fixes into separate issues then.

#26

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.