Closed (fixed)
Project:
Flickr
Version:
6.x-1.0-alpha1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Aug 2008 at 13:53 UTC
Updated:
20 Nov 2008 at 17:32 UTC
Jump to comment: Most recent
Hello, I've installed Flickr module, and while entering the admin form, I have the following php warning:
Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of system_settings_form_submit(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /home/.../drupal/sites/all/modules/flickr/flickr.admin.inc on line 87
Flickr module functions normally (as described) and i have no similar warning for other modules.
Hope it can help for a further setup
Comments
Comment #1
neosis commentedSame issue with me.
Comment #2
msonnabaum commentedChange this line:
system_settings_form_submit($form, &$form_state);
to this:
system_settings_form_submit($form, $form_state);
From http://www.php.net/manual/en/language.references.pass.php:
"Function definition alone is enough to correctly pass the argument by reference. In recent versions of PHP you will get a warning saying that "Call-time pass-by-reference" is deprecated when you use a & in foo(&$a);."
Comment #3
Anonymous (not verified) commentedCouldn't reproduce this problem with the latest code out of CVS HEAD.
system_settings_form_submit($form, &$form_state);
.. also looks correct. We always pass around the $form_state parameter by reference.
Please reopen if you need any further assistance.
Best, Paul