I installed the img_assist in the version from yesterday (15th August) and entered the image_assist configuration (q=admin/settings/img_assist). I cannot save config page, nor revert to default, since "Caption title pattern field is required." I cannot enter anything in the corresponding field since I dont have Token installed.

If it were a real dependency, img_assist shouldn't allow me to install the module in the first place.

I assume the problem will disappear when I install token...

CommentFileSizeAuthor
#5 img_assist-pattern.patch1009 bytessmk-ka
#1 img_assist-DRUPAL-6--2.token_.patch1.06 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: cannot save options and quasi-dependence to token. » Module settings cannot be saved without Token module
Component: Miscellaneous » Code
Status: Active » Needs review
StatusFileSize
new img_assist-DRUPAL-6--2.token_.patch1.06 KB

Please test attached patch.

zoo33’s picture

zoo33 commented

Haven't tested, but it looks solid. Maybe commit and let people test the -dev version?

AltaVida’s picture

AltaVida commented

This patch fixed the problem for me.

zoo33’s picture

zoo33 commented
Status: Needs review » Reviewed & tested by the community

Great, thanks!

smk-ka’s picture

smk-ka commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new img_assist-pattern.patch1009 bytes

IMO admins shouldn't be forced to enter *any* text at all, since title and description are clearly stated as optional in the Image Assist property dialog. New patch removes the #required attribute alltogether, giving the possibility to leave both fields empty.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

I think smk-ka is right.

Committed to all branches.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.