Closed (fixed)
Project:
Project
Version:
7.x-2.x-dev
Component:
Projects
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
16 Aug 2008 at 10:30 UTC
Updated:
29 Nov 2018 at 22:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dwwPatches for HEAD of project, project_issue, and project_issue_voting. Tested locally and working fine. Any objections?
Comment #2
dwwWhoops, sorry, that was the wrong patch for project + project_release. Use this one (the *.project_issue* patches from #1 are still fine).
Comment #3
aclight commentedMy only concern about this going in is that then if a site starts out with only the project and project_release modules, for example, and then someone creates a project called "issues" or "voting", but then later the site wants to also install project_issue and project_voting, there will be problems.
On the flip side, once we start using views the paths that a site might use open up termendously, since things won't be hard coded. So there's the potential that a site that uses non-default paths for the various views might either need to restrict the list of possible projects even further, or may not need to restrict them at all. So having a hook that the site admin could use would be very beneficial.
Maybe we want to add something to hook_requirements that displays a warning if there are collisions between project names and any of the reserved names that come up at a given time from calling this new hook? At least then the site admin could fix things before they got too ugly.
Comment #4
hunmonk commentedi want to get rid of the reserved name stuff altogether, so i don't like the idea of adding in a hook for it now. i have an issue floating around somewhere for that...
Comment #5
dwwI find it impossible that we'll be able to completely get rid of them, and a hook seems better than hard-coding for many reasons. But, if a link to hunmonk's issue materializes, I'll take a look. ;) I think the hook_requirements() check would be a nice touch as a follow-up issue/patch.
Comment #6
aclight commentedhunmonk's issue is #180316: fix project/mymodule URI insanity.
Comment #8
drummRe-rolled & committed. Thanks!
This is useful for https://docs.gitlab.com/ee/user/reserved_names.html#reserved-project-names
Comment #10
drumm