Port Upgrade Status/Assist to 6.x

This is actually created from HEAD. I'm getting a whitescreen for some reason but can't look into it right now. It's a good start!

subscribing.

subscribe

sub

Is anyone working on this?

fm, I attached a patch at http://drupal.org/node/297335#comment-1064709 . If anyone wants to fix it, please be my guest ;-) .

Better title.

subscribe

subscribe

Needs hook_theme() in the .module file. That stops the WSOD, but it still doesn't work. I'm having a look through it. I'll post a patch if I get it working.

Right, ran through deadwood, poked around a bit, and Upgrade Status is now working. I haven't tested it exhaustively though, there might be some other things that need fixing. I haven't tested Upgrade Assist at all..

This is relevant to #D7CX

@@ -695,11 +698,11 @@ function upgrade_status_project_cache($c
-    '#options' => drupal_map_assoc(array('6.x', '7.x')),
+    '#options' => drupal_map_assoc(array('7.x','8.x')),

Missing space after array element.

@@ -1,10 +1,10 @@
 ; Information added by drupal.org packaging script on 2008-12-10
-version = "5.x-1.x-dev"
+version = "6.x-1.x-dev"
 project = "upgrade_status"
 datestamp = "1228868175"
-

Looks like this patch wasn't created against CVS?

@@ -24,45 +24,45 @@ function upgrade_status_help($section) {
+  $items['admin/reports/updates/upgrade'] = array(
+    'title' => 'Upgrade status',
+    'page callback' => 'upgrade_status_status',
+    'access callback' => 'user_access',
+    'access arguments' => array('administer site configuration'),
       'type' => MENU_LOCAL_TASK,
       'weight' => 10,
+    'file' => 'upgrade_status.admin.inc'
     );

(and elsewhere) Wrong indentation of old/unchanged code.

Also, 'user_access' does not need to be specified as 'access callback', it's the default.

@@ -24,45 +24,45 @@ function upgrade_status_help($section) {
 }
-

Please keep another blank line at the end of files.

This review is powered by Dreditor.

Aside from that, I've committed this patch - without testing.

Thanks!

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

sun: you're game :P

Reckon you could put out a 6.x dev release? Would be good to start getting bug reports before drupal 7 gets close.

I already did that; just happened to be invisible. Now available.

How stable is the dev release? The issue queue doesn't reveal much.

Aren, aren't you long enough a Drupal user to know the answer to this question?

I've seen some remarkably stable devs...