Port Upgrade Status/Assist to 6.x

lomz - August 19, 2008 - 20:49
Project:Upgrade Status
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:D7CX
Description

I would like a D6 version of this module.

#1

Rob Loach - October 17, 2008 - 20:27
Version:5.x-1.2» 5.x-1.x-dev
Status:active» needs work

This is actually created from HEAD. I'm getting a whitescreen for some reason but can't look into it right now. It's a good start!

AttachmentSize
297335.patch 7.15 KB

#2

fm - October 20, 2008 - 16:26

subscribing.

#3

ahkiam - January 3, 2009 - 06:47

subscribe

#4

SeanBannister - February 22, 2009 - 04:31

sub

#5

fm - April 4, 2009 - 03:08

Is anyone working on this?

#6

Rob Loach - April 6, 2009 - 13:11

fm, I attached a patch at http://drupal.org/node/297335#comment-1064709 . If anyone wants to fix it, please be my guest ;-) .

#7

sun - April 18, 2009 - 01:56
Title:Upgrade to D6.x» Port Upgrade Assist to 6.x

Better title.

#8

NancyDru - June 5, 2009 - 16:03

subscribe

#9

Aren Cambre - June 12, 2009 - 19:47

subscribe

#10

naught101 - July 26, 2009 - 03:14

Needs hook_theme() in the .module file. That stops the WSOD, but it still doesn't work. I'm having a look through it. I'll post a patch if I get it working.

#11

naught101 - July 26, 2009 - 04:21
Status:needs work» needs review

Right, ran through deadwood, poked around a bit, and Upgrade Status is now working. I haven't tested it exhaustively though, there might be some other things that need fixing. I haven't tested Upgrade Assist at all..

AttachmentSize
upgrade_status6.patch 11.44 KB

#12

naught101 - July 26, 2009 - 04:00

This is relevant to #D7CX

#13

naught101 - July 26, 2009 - 04:21
Title:Port Upgrade Assist to 6.x» Port Upgrade Status/Assist to 6.x

#14

sun - August 2, 2009 - 01:32

@@ -695,11 +698,11 @@ function upgrade_status_project_cache($c
-    '#options' => drupal_map_assoc(array('6.x', '7.x')),
+    '#options' => drupal_map_assoc(array('7.x','8.x')),

Missing space after array element.

@@ -1,10 +1,10 @@
; Information added by drupal.org packaging script on 2008-12-10
-version = "5.x-1.x-dev"
+version = "6.x-1.x-dev"
project = "upgrade_status"
datestamp = "1228868175"
-

Looks like this patch wasn't created against CVS?

@@ -24,45 +24,45 @@ function upgrade_status_help($section) {
+  $items['admin/reports/updates/upgrade'] = array(
+    'title' => 'Upgrade status',
+    'page callback' => 'upgrade_status_status',
+    'access callback' => 'user_access',
+    'access arguments' => array('administer site configuration'),
       'type' => MENU_LOCAL_TASK,
       'weight' => 10,
+    'file' => 'upgrade_status.admin.inc'
     );

(and elsewhere) Wrong indentation of old/unchanged code.

Also, 'user_access' does not need to be specified as 'access callback', it's the default.

@@ -24,45 +24,45 @@ function upgrade_status_help($section) {
}
-

Please keep another blank line at the end of files.

This review is powered by Dreditor.

#15

sun - August 2, 2009 - 01:37
Status:needs review» fixed

Aside from that, I've committed this patch - without testing.

Thanks!

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

#16

naught101 - August 2, 2009 - 03:33
Status:fixed» active

sun: you're game :P

Reckon you could put out a 6.x dev release? Would be good to start getting bug reports before drupal 7 gets close.

#17

sun - August 2, 2009 - 14:12
Status:active» fixed

I already did that; just happened to be invisible. Now available.

#18

System Message - August 16, 2009 - 14:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.