The search form is frequently to wide for many pages, over-running the width of a 640 wide screen. It inconveniently runs under the navigation bar on the Drupal main site in Firefox, for example.

CommentFileSizeAuthor
#3 issue-select-width.patch1.22 KBnedjo

Comments

moggy’s picture

agreed, I'm running at 1024x768 and the "advanced search" link is hidden by default, If I select "all" status' then that select box fills the whole screen. It's always been like that, but the new status' have made it worse.

Question is, is it a problem for themes to solve or this module to solve.

Themes could specify a maximum width of the select boxes so that they don't expand to fill the whole page themselves.

The project module could rearrage the layout of thesearch options:
- put a break after the project selection box, so that it's on the first line, like a kind of heading, then the rest of the options on the line below. That would aleviate some of the problem.
- we could perhaps change the names of the status' to something shorter
- When selecting "All" status', please don't list the status' just show "All"

That's my initial thoughts. I don't have time to poke the code at the moment though.

nedjo’s picture

This issue is largely a result of the new status options, which are longer strings than previously, and so make the select box wider. One quick fix would be to change the (hardcoded) default list of status options.

nedjo’s picture

Status: Active » Needs review
StatusFileSize
new1.22 KB

Attached patch should fix the issue by assigning fixed widths to the project and issue status selects. It also fixes an unrelated bugs that was preventing the filter form from working in CVS.

dries’s picture

Status: Needs review » Needs work

It's much better to modify project.css than to add inline CSS ...

nedjo’s picture

Status: Needs work » Fixed

It's much better to modify project.css than to add inline CSS ...

Right, done and applied.

nedjo’s picture

Status: Fixed » Active

Although the fix worked on my local system, it hasn't on drupal.org. CSS overrides from the custom drupal.org theme?

nedjo’s picture

Status: Active » Fixed

Working now on drupal.org. Thanks, whoever fixed this!

Anonymous’s picture

Status: Fixed » Closed (fixed)