Download & Extend
Issues

HEAD broken: Database engine initialization during install failure

Posted by Rob Loach on August 21, 2008 at 11:53pm
Project:Drupal core
Version:7.x-dev
Component:database system
Category:bug report
Priority:critical
Assigned:chx
Status:closed (fixed)

Issue Summary

When installing a fresh HEAD from CVS, you get a fatal error because it attempts to initialize a database engine that doesn't exist (CVS). This is because it sees the CVS folder, and assumes it's a database engine.

AttachmentSizeStatusTest resultOperations
databaseinstall.patch640 bytesIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by Rob Loach on August 21, 2008 at 11:56pm
Status:needs review» needs work

http://us3.php.net/glob FTW

#2

Posted by Rob Loach on August 22, 2008 at 12:43am
Status:needs work» needs review

Thoughts?

AttachmentSizeStatusTest resultOperations
databaseinstall.patch1.22 KBIgnored: Check issue status.NoneNone

#3

Posted by Rob Loach on August 22, 2008 at 1:05am
Title:Class 'DatabaseInstaller_CVS' not found in includes/install.inc» Database engine initialization during install failure
Assigned to:Anonymous» Rob Loach

Changing title to be a bit more descriptive.

#4

Posted by moshe weitzman on August 22, 2008 at 2:04am
Priority:normal» critical

bit me too.

#5

Posted by xmacinfo on August 22, 2008 at 3:04am

CVS update forces an install, too, giving out the same errors as a fresh install.

#6

Posted by Crell on August 22, 2008 at 5:30am
Status:needs review» reviewed & tested by the community

Yeah, that one's my fault. The patch in #3 fixes it, but is not super approachable. The attached patch is identical except for the addition of some comments. No other changes. Dries, please just credit Rob.

AttachmentSizeStatusTest resultOperations
databaseinstall.patch1.57 KBIgnored: Check issue status.NoneNone

#7

Posted by lilou on August 22, 2008 at 11:51am

Install work now for me.

#8

Posted by catch on August 22, 2008 at 12:28pm
Title:Database engine initialization during install failure» HEAD broken: Database engine initialization during install failure

I posted a duplicate, this one's good.

#9

Posted by Dries on August 22, 2008 at 12:44pm
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks!

#10

Posted by chx on August 24, 2008 at 4:58am
Assigned to:Rob Loach» chx
Status:fixed» reviewed & tested by the community

This is incorrect. I am surprised noone asked "huh? max on an array of strings? what that could mean?" max manual says:

the alphabetical highest string value will be returned.

so as soon as someone adds a db2 or firebird directory in there, you will end up with a driver called "includes". This is easy to avoid...

AttachmentSizeStatusTest resultOperations
max_is_not_array_last_function.patch545 bytesIgnored: Check issue status.NoneNone

#11

Posted by Rob Loach on August 24, 2008 at 6:24am

There we go! Thanks a lot, chx! You're my hero..... I knew max looked weird....

#12

Posted by keith.smith on August 24, 2008 at 10:19am

Oddly, I still had trouble, with the error that a text blob could not have a default value.

To get my Drupal 7 to install tonight, I had to use the following patch (which may have an entire host of consequences I don't understand, so use at your own risk).

Edit: Oh--and I don't really want to remove the RTBC on the earlier patch, though it did not work for me.

AttachmentSizeStatusTest resultOperations
functional_installation.patch1.23 KBIgnored: Check issue status.NoneNone

#13

Posted by Heine on August 24, 2008 at 10:25am

@keith.smith; your problem "a default on a text field" is distinct from the "wrong db driver selection during install". Can you please open a new issue?

#14

Posted by keith.smith on August 24, 2008 at 10:32am

My apologies for derailing the issue. I created another issue at http://drupal.org/node/299292.

#15

Posted by Freso on August 24, 2008 at 11:38am

Both with and without this patch, I'm getting Fatal error: Class 'PDO' not found in /srv/http/localhost/htdocs/drupal7/includes/database/database.inc on line 137

#16

Posted by Freso on August 24, 2008 at 11:39am

(And I'm not seeing the "CVS" error either way either.)

#17

Posted by catch on August 24, 2008 at 12:34pm

Freso - do you definitely have PDO compiled into your PHP install? I've opened a new issue here for adding PDO to system requirements #299308: Installing Drupal by visiting index.php (rather than install.php) leads to a fatal error when PDO is not enabled. This error will only show up with a CVS checkout, not wit 7.x-dev tarball.

I

#18

Posted by Rob Loach on August 24, 2008 at 5:16pm

Both patches, #10 and #12, are good to go. Although, #12 is somewhat unrelated to this issue.

#19

Posted by chx on August 24, 2008 at 8:28pm

#10 must go in.

#20

Posted by Freso on August 25, 2008 at 7:46am

#17: I can very much verify that I do not have PDO compiled in (I didn't know that was a requirement now either). Sorry for wasting everybody's time. :$

/me makes a mental note to add "pdo" to PHP's USE-flags when he gets home from work...

#21

Posted by Dries on August 25, 2008 at 7:49am
Status:reviewed & tested by the community» fixed

I've committed #10. Let's create a new issue for #12. Thanks all.

#22

Posted by Anonymous (not verified) on September 11, 2008 at 5:32am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#23

Posted by nikemen on September 26, 2008 at 3:22pm

Well, doesn't work for me though I have PHP 5.2.6 with PDO installed. Help!

#24

Posted by nikemen on September 27, 2008 at 1:11pm
Status:closed (fixed)» active

#25

Posted by Rob Loach on September 27, 2008 at 8:33pm
Status:active» fixed

If you're getting any errors with Drupal HEAD, open up a new issue and post in what warnings/errors your getting. This fix went in.

#26

Posted by Crell on September 27, 2008 at 9:03pm
Status:fixed» closed (fixed)
nobody click here