Posted by izmeez on August 24, 2008 at 7:33pm
Jump to:
| Project: | Profile Privacy |
| Version: | 6.x-1.1.1 |
| Component: | Miscellaneous |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
This is a suggestion for a minor cosmetic change.
When user is allowed to over ride default settings the text displayed to the user with the check box is "Do not display publicly". This can be misleading in setups where the fields are only displayed to registered users. Even though this may be stated in the instructions provided along with the fields it may be helpful to replace the word "publicly" with "to regular users". This would need to be changed in the module when the word "publicly" appears the second time.
$form[$category][$key]['#description']);
// Create the privacy checkbox
$privacy_checkbox = array();
$privacy_checkbox['private_'. $key] = array(
'#type' => 'checkbox',
'#title' => t('Do not display !field publicly', array('!field' => Maybe there is some other phrase that would be better to use. Thanks for your consideration. I look forward to being able to use this module.
Izzy
Comments
#1
I don't find "to regular users" to be more informative than "publicly". What constitutes a "regular" user? Of course the same problem exists for what's considered "public", so the problem exists either way.
If you wish to change the string, you might consider doing a hook_form_alter() to change the string, or use String Overrides module.
#2
I agree that "to regular users" isn't a particularly great term but it may help to distinguish between the general public and other authenticated users, whereas the word "publicly" does not make that distinction. It would be nice to find a better term but in the meantime it is easy enough to make a custom change to the module and change the second occurrence of the word "publicly" for those so inclined, like us.
Thanks for this very useful module. One that we consider essential.
Izzy
#3
Rather than altering the module you should use http://drupal.org/project/stringoverrides
I'm open to other words, but yes, "regular users" isn't right. Since user profile access is decided by roles it should technically follow which roles have that permission. Putting issue to 'needs more info' to get some other ideas. This isn't a high priority for me unfortunately.
#4
"Hide from anonymous users" -- More clear and concise - uses a Drupal role term for clarity.
"Show to registered users" or "Show to permissioned users"
#5
Greta, the issue here is that Profile Privacy doesn't distinguish between authenticated or anonymous users. Rather, this module hides the fields from everyone. If you wanted to have a field shown to some users (e.g. those with a particular role or permission) but not to anonymous users, then this would involve something different. See the discussion in #434154: Allow users to make whole profile public/private for more information on how this might be accomplished using Panels. If you use Profile Privacy for fields that you want to hide from everyone, and then use Panels for fields that you want to hide from people with specific roles, then this would allow the most flexibility. However, based on this, you'd still need to reword the Profile Privacy check-box so that it makes sense given how you are showing the fields in the Panels. My guess is that it would be best to use a generic phrase such as "Show to authorized users" so that it begs the question of who is authorized, and then separately (using other custom profile fields), allow the user to specify who is authorized to view fields. Finally, add a check-box that says "Make entire profile private (overrides all other privacy settings)" and displaying an appropriate panel if the condition is not met.
#6
I suggest we wait until this is fixed, as it allows users to decide for themselves: http://drupal.org/node/156082
#7
ok, I didn't understand the significance of the link in comment #6 as it just seems to point to a dying thread and doesn't have any patches to test that I could see.
#8
Respectfully marking as won't fix, because "public" might mean either registered users or even unregistered users depending on how user profile permissions are configured. I think there are too many variables here to set a more defined value in the module, but the String Overrides module as mentioned above or the using the core override method in the settings.php file allows site builders to change the text to what they feel best matches their site's configuration without having to hack the module. Therefore a viable alternatives currently exists.