As outlined in #290562: Re-implement Taxonomy support in image browser, IA currently loads the corresponding contents for the upper popup window frame after loading the lower frame. This prevents us from configuring the default image thumbnail browser view - and also makes the popup's mechanisms more complicated than it needs to be.

We do not need frames in the popup window, and re-factoring it will also open the doors for modal dialogs, AHAH, and the like.

smk-ka already started to work on this. However, this requires also a rewrite of all the JavaScript (which is good).

CommentFileSizeAuthor
#2 frameset.patch38.4 KBscroogie
#2 frameset.patch38.4 KBscroogie

Comments

minhajj’s picture

minhajj commented

hi
i m trying to open a popup window by using secondary link of drupal how can i write code to open a popup windw in secondary link which is a external url please help me do this

scroogie’s picture

scroogie commented
Status: Active » Needs work
StatusFileSize
new frameset.patch38.4 KB
new frameset.patch38.4 KB

I've started to take a look at eliminating the frameset. Here is an absolutely preliminary patch that removes the frames.
It only works with textareas, and changes quite a lot.
I will continue to work on it, but I thought I'd already post this work in progress, to get input from you. Especially on what Inline API and WYSIWYG API should take over.

My next step is saving the editor-type and html element in the opener doc, instead of passing them around in the URL.

Biggest changes:
- no frameset
- no "thumbs" page
- editor and element name as parameters to pages (probably wrong)
- always let the insert form submit to generate the code (inline or html) in php (probably debatable)
- use an exposed views filter for taxonomy term filtering, instead of custom code
- a lot of other changes

Note: This may break absolutely everything and is just to get the ball rolling.

scroogie’s picture

scroogie commented

Apparently I'm eating kittens here, or so I was told, so I'm going to rewrite it. I shouldn't have let the taxonomy stuff sidetrack me. Expect a new patch somewhen around wednesday.

scroogie’s picture

scroogie commented

Mhm, wondering if this is of any use still. I doubt it, but I still think it would be nice to get the frameset eliminated and leave filtering to views before we add further functionality, because it changes the architecture so much.

dboulet’s picture

dboulet commented

We do not need frames in the popup window, and re-factoring it will also open the doors for modal dialogs, AHAH, and the like.

Agreed. Opening a frameset in a new window??? So 1999... ;).