Similar to the radios issue which was recently fixed. I have tested this patch in Drupal 6.

CommentFileSizeAuthor
#2 form.inc-299742-2_HEAD.patch1.03 KBdarren oh
#2 form.inc-299742-2_DRUPAL-6.patch1.04 KBdarren oh
form.inc_DRUPAL-6.patch1.01 KBdarren oh
form.inc-HEAD.patch1 KBdarren oh

Comments

fuerst’s picture

fuerst commented

Having #ahah working for #type checkboxes is a nice addition.

form.inc_DRUPAL-6.patch against Drupal 6.5 succeeded and works as advertised.

Had no chance to test using HEAD yet.

How to proceed to get this included into core?

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
StatusFileSize
new form.inc-299742-2_DRUPAL-6.patch1.04 KB
new form.inc-299742-2_HEAD.patch1.03 KB

Well, the patches needed to be updated to match the latest core versions. In your next reply, set this issue to "reviewed and tested". The patches are exceedingly simple (and identical to the one used to fix radio boxes), so don't worry if someone scolds you for changing the status.

fuerst’s picture

fuerst commented
Status: Needs review » Reviewed & tested by the community

Both patches succeeded using Drupal 6.5 / Drupal 7-dev.
I validated the functionality using Drupal 6.5.

So, it's ready to be included into the next release, hopefully.

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev

Committed to CVS HAED hit.

yang_yi_cn’s picture

yang_yi_cn commented
Status: Reviewed & tested by the community » Needs review

I'm not sure if I'm doing correctly, but I tested it and it's not working. The patch was applied with not warnings, but the checkboxes still doesn't work for #ahah.

I tried to add a checkboxes widget by ahah. The submission is by click a button with #ahah property, and if I insert a textfield or select, it works as expected, but if I try to insert a checkboxes widget, it only shows the rendered checkboxes form-item, not any of the options. I tried to trace the code and find expand_checkboxes() in form.inc is not even getting called. Is it the same issue of the patch trying to fix or another issue?

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Needs review » Patch (to be ported)

That's a different problem. This patch lets you make checkboxes do things when you click on them.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Patch (to be ported) » Reviewed & tested by the community

Oops. Already ported. Just needs to be committed.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Looks good, reviewed and committed to 6.x! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Alex Savin’s picture

Alex Savin commented
Version: 6.x-dev » 6.12

Still I can not get ahah to create dynamic checkboxes elements. If I change the type of the element in select than everything works ok.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Version: 6.12 » 6.x-dev

Please see comment #6.