i18nmenu Does not work with DHTML menu (report+patch)

Problem

DHTML menu is a module that avoids page reloads when browsing menus ; hierarchical menu items are clickable and uncollapse using javascript to show the sub menu items.

The problem is that when using this module, sub-menu items under branches which are not in the current path do not get translated.

Note that, at the time of writting, to run DHTML menu with i18nmenus the following patch is needed : http://drupal.org/node/298720

Analysis

The problem seems to be that i18nmenu_translated_tree calls menu_tree_page_data which only returns menu data in the current path ; and thus only translates those. However, DHTML menu displays all menu items since they can all be unfolded without a page reload.

This problem is not necessaraly specific to DHTML menu - other modules could have the same problem. i18nmenu_translated_tree cannot make assumptions as to what the tree is going to be used for, and thus must translate all items.

Patch

The following patch fixes the problem :

Index: modules/i18n/i18nmenu/i18nmenu.module
===================================================================
--- modules/i18n/i18nmenu/i18nmenu.module       (revision 1295)
+++ modules/i18n/i18nmenu/i18nmenu.module       (working copy)
@@ -76,7 +76,7 @@
   static $menu_output = array();

   if (!isset($menu_output[$menu_name])) {
-    $tree = menu_tree_page_data($menu_name);
+    $tree = menu_tree_all_data($menu_name);
     i18nmenu_localize_tree($tree);
     $menu_output[$menu_name] = menu_tree_output($tree);
   }