Thanks for releasing a version for Drupal 6!

I have installed the module, set up the permissions and the admin settings. On users settings page, I get the error message: "Your e-mail address must be specified on your my account page." The words "my account" are linked to "user/%2Fedit".

CommentFileSizeAuthor
#13 notify-300280-12.patch559 bytesjackalope

Comments

matt2000’s picture

Status: Active » Fixed

Thanks, I've made some corrections to the code. Look for a new -dev snapshot.

matt b’s picture

Status: Fixed » Active

ok the error message link is now correct, however the error is occurring on all accounts, and they have complete and correct email addresses - I shouldn't be seeing the error message...

matt2000’s picture

Status: Active » Postponed (maintainer needs more info)

I can't duplicate, but I'm guessing the problem is related to pre-exisiting users who have no entry in the notify table.

I changed it so that even when the warning is thrown, the settings form will still be displayed. Submitting the form will create an entry in Notify, so if my guess is right, it will solve your problem.

matt b’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

My notfiy table did not have the teasers or comments fields (I had previously heavily modified notify for my purposes). Uninstalled notify and re-installed and it works fine.

derieppe’s picture

Version: 6.x-1.x-dev » 5.x-2.x-dev

Hello,

I'v download this module in 5.X-2.X-dev version yesterday.

Got same bugs :

1° Only user #1 cant view his notification settings in user/1/notify (or by tab).
2° Message say "Your e-mail address must be specified on your my account page.".
3° The link in the message "my account" is to user/0/notify.

Did you patch this version ?
Regards.

derieppe’s picture

Status: Closed (fixed) » Postponed (maintainer needs more info)

Re open the case.

Rene de Boer’s picture

i had the same problem. No email sent and no acces to my account. The problem occured when i uninstalled the module and later installed it again. Before the modele worked perfect, after reinstalling the stable module it did nothing and gave the above errors. After i installed the (unstable?) dev version everything works oke.

Rene

jtjones23’s picture

I get the same error message ("Your e-mail address must be specified on your my account page.") when installing 5.x-1.2

Drupal 5.15
PHP 5.2.8

NaX’s picture

Component: User interface » Code
Status: Postponed (maintainer needs more info) » Active

I wonder if this is related to this issue.
http://drupal.org/node/360729#comment-1208734

Rene de Boer’s picture

i have copied the above code in the module, doing the php-update but still the problem remains.

So i have reinstalled the dev-version again. It works, but gives a not secure warning.

Rene

elek’s picture

There is a bug in function notify_user_settings_form():

  if ($user->uid != $arg->uid && $user->uid != 1) {
    drupal_access_denied();
    return;
  }

  $account = user_load(array('uid' => $arg->uid));
  if (!is_object($account)) {
    drupal_not_found();
    return;
  }

"$arg->uid" should be "$uid"

  if ($user->uid != $uid && $user->uid != 1) {
    drupal_access_denied();
    return;
  }

  $account = user_load(array('uid' => $uid));
  if (!is_object($account)) {
    drupal_not_found();
    return;
  }

then it works ...

Rene de Boer’s picture

It works. Thank you very much!!

Rene

jackalope’s picture

Version: 5.x-2.x-dev » 5.x-1.2
Status: Active » Needs review
StatusFileSize
new559 bytes

elek's solution in #11 worked for me. Created a quick patch for it here.

matt2000’s picture

Status: Needs review » Fixed

patch reviewed & committed. Please test new dev release.

NaX’s picture

This issue has the same fix and maybe should be closed or marked as a duplicate.
http://drupal.org/node/360729#comment-1208734

emdalton’s picture

Confirmed fix works on our system.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

1kenthomas’s picture

Looks to be fixed in current -dev, as well ;)