My Settings / Notification Settings page

Matt B - August 26, 2008 - 20:12
Project:Notify
Version:5.x-1.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Thanks for releasing a version for Drupal 6!

I have installed the module, set up the permissions and the admin settings. On users settings page, I get the error message: "Your e-mail address must be specified on your my account page." The words "my account" are linked to "user/%2Fedit".

#1

matt2000 - August 27, 2008 - 14:08
Status:active» fixed

Thanks, I've made some corrections to the code. Look for a new -dev snapshot.

#2

Matt B - August 29, 2008 - 06:35
Status:fixed» active

ok the error message link is now correct, however the error is occurring on all accounts, and they have complete and correct email addresses - I shouldn't be seeing the error message...

#3

matt2000 - August 30, 2008 - 03:48
Status:active» postponed (maintainer needs more info)

I can't duplicate, but I'm guessing the problem is related to pre-exisiting users who have no entry in the notify table.

I changed it so that even when the warning is thrown, the settings form will still be displayed. Submitting the form will create an entry in Notify, so if my guess is right, it will solve your problem.

#4

Matt B - August 30, 2008 - 06:52
Status:postponed (maintainer needs more info)» closed

My notfiy table did not have the teasers or comments fields (I had previously heavily modified notify for my purposes). Uninstalled notify and re-installed and it works fine.

#5

derieppe - October 24, 2008 - 12:36
Version:6.x-1.x-dev» 5.x-2.x-dev

Hello,

I'v download this module in 5.X-2.X-dev version yesterday.

Got same bugs :

1° Only user #1 cant view his notification settings in user/1/notify (or by tab).
2° Message say "Your e-mail address must be specified on your my account page.".
3° The link in the message "my account" is to user/0/notify.

Did you patch this version ?
Regards.

#6

derieppe - October 24, 2008 - 12:37
Status:closed» postponed (maintainer needs more info)

Re open the case.

#7

Rene de Boer - January 8, 2009 - 09:46

i had the same problem. No email sent and no acces to my account. The problem occured when i uninstalled the module and later installed it again. Before the modele worked perfect, after reinstalling the stable module it did nothing and gave the above errors. After i installed the (unstable?) dev version everything works oke.

Rene

#8

jt_jones - January 16, 2009 - 17:19

I get the same error message ("Your e-mail address must be specified on your my account page.") when installing 5.x-1.2

Drupal 5.15
PHP 5.2.8

#9

NaX - January 19, 2009 - 14:33
Component:User interface» Code
Status:postponed (maintainer needs more info)» active

I wonder if this is related to this issue.
http://drupal.org/node/360729#comment-1208734

#10

Rene de Boer - January 25, 2009 - 11:00

i have copied the above code in the module, doing the php-update but still the problem remains.

So i have reinstalled the dev-version again. It works, but gives a not secure warning.

Rene

#11

elek - January 29, 2009 - 10:06

There is a bug in function notify_user_settings_form():

  if ($user->uid != $arg->uid && $user->uid != 1) {
    drupal_access_denied();
    return;
  }

  $account = user_load(array('uid' => $arg->uid));
  if (!is_object($account)) {
    drupal_not_found();
    return;
  }

"$arg->uid" should be "$uid"

  if ($user->uid != $uid && $user->uid != 1) {
    drupal_access_denied();
    return;
  }

  $account = user_load(array('uid' => $uid));
  if (!is_object($account)) {
    drupal_not_found();
    return;
  }

then it works ...

#12

Rene de Boer - January 29, 2009 - 18:26

It works. Thank you very much!!

Rene

#13

jackaponte - February 2, 2009 - 17:25
Version:5.x-2.x-dev» 5.x-1.2
Status:active» needs review

elek's solution in #11 worked for me. Created a quick patch for it here.

AttachmentSize
notify-300280-12.patch 559 bytes

#14

matt2000 - February 3, 2009 - 01:54
Status:needs review» fixed

patch reviewed & committed. Please test new dev release.

#15

NaX - February 3, 2009 - 08:51

This issue has the same fix and maybe should be closed or marked as a duplicate.
http://drupal.org/node/360729#comment-1208734

#16

emdalton - February 9, 2009 - 17:51

Confirmed fix works on our system.

#17

System Message - February 23, 2009 - 18:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#18

1.kenthomas - February 24, 2009 - 04:25

Looks to be fixed in current -dev, as well ;)

 
 

Drupal is a registered trademark of Dries Buytaert.