The new Views based browser requires a few changes to the CSS code. Attached is a rerolled version of the patch submitted in this comment. And here is a copy of the description:

First, let me point out that the IA window looks completely different depending on if you use it with TinyMCE or not. With TinyMCE, we get only TinyMCE's css file and img_assist.css. Without TinyMCE, IA includes all the regular Drupal CSS files including the theme's files – and then img_assist.css. (This is the intended behavior, take a look at theme_img_assist_page().)

In this patch:

– Removed unnecessary declarations.
– Hided .views-admin-links. (This is first and foremost needed with TinyMCE.)
– Added overrides for table styling. Garland for instance adds borders and margins to it's tables which doesn't work well here.
– Centered tables and node forms with margin: auto since we removed

from the markup.
CommentFileSizeAuthor
img_assist-popup_css-080827.patch1 KBzoo33

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review

Ugh. A patch! :)

zoo33’s picture

zoo33 commented

Bump. This is a simple enough patch, and I did put some effort into making sure it's solid. RTBC?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Of course! Just change "Browser Window" into "Browser window" before committing, please :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Ah, I forgot - just to be sure, also add a CHANGELOG.txt entry for each commit, please.

AltaVida’s picture

AltaVida commented

I don't know if I should open a new issue or not but this seems related:

The default view for img_assist uses a pager. But without the drupal css files being loaded (when using TinyMCE), the pager is not styled correctly. It shows as an ugly bulleted list.

I've read the comment in theme_img_assist_page() that explains why drupal's css is not loaded when invoked as part of TinyMCE but I still don't really get it. Not allowing theming of the img_assist popup by themers and developers seems very un-drupal like.

Am I missing something?

scroogie’s picture

scroogie commented

It is a seperate issue, but I agree with you AltaVida. It should load all the usual CSS files, and don't mess with the order.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.