[DBTNG + BLOB]: remap {watchdog}.variables
hswong3i - August 28, 2008 - 05:58
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | watchdog.module |
| Category: | feature request |
| Priority: | critical |
| Assigned: | hswong3i |
| Status: | duplicate |
Description
As case mentioned in http://drupal.org/node/147947, this patch remap {watchdog}.variables as BLOB type. Also merge with http://drupal.org/node/300219 for correct schema definition. A SELECT query for dblog_top() is also updated according invalid GROUP BY with BLOB.
MySQL:
- update.php: pass.
- INSERT/SELECT (Top * in...): pass.
PostgreSQL:
- update.php: FAILED. Seems PostgreSQL schema don't handle change field correctly.
- INSERT: FAILED. Seems db_insert() of PostgreSQL don't handle correctly.
| Attachment | Size |
|---|---|
| watchdog-variables.patch | 4.72 KB |
| Testbed results | ||
|---|---|---|
| watchdog-variables.patch | failed | Failed: Failed to apply patch. Detailed results |
#1
Update based on http://drupal.org/node/316095 founding. Revamp BLOB field with nullable.
Tested with MySQL and PostgreSQL. Stand alone simpletest, pass.
#2
Integrate with progress of http://drupal.org/node/319401.
Tested with MySQL and PostgreSQL, DBLog simpletest all pass.
#3
Since #316095: [DBTNG + pgsql] db_insert/db_update buggy with empty string input and BLOB field already figure out the solution for PostgreSQL + BLOB + NULL + INSERT/UPDATE bug, this patch is now safe for using both null or nullable BLOB field.
Patch reroll via CVS HEAD. Only change field type from TEXT to BLOB.
P.S. Actually, I would like to add default value for "variables" as it is
'not null' => TRUEby default. But since MySQL will buggy with #300219: [DBTNG]: MySQL should remove TEXT/BLOB default value so I would like to wait and handle this with another issue.#4
According to commit of #300219: [DBTNG]: MySQL should remove TEXT/BLOB default value, patch reroll via CVS HEAD. Tested with MySQL's simpletest.
#5
The last submitted patch failed testing.
#6
Ooops... dblog.install need update. Patch reroll and pass MySQL + simpletest.
#7
The last submitted patch failed testing.
#8
See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476
#9
duplicate with #147947: [DBTNG + XDB] Replace some TEXT:BIG with BLOB