As case mentioned in http://drupal.org/node/147947, this patch remap {watchdog}.variables as BLOB type. Also merge with http://drupal.org/node/300219 for correct schema definition. A SELECT query for dblog_top() is also updated according invalid GROUP BY with BLOB.

MySQL:

  • update.php: pass.
  • INSERT/SELECT (Top * in...): pass.

PostgreSQL:

  • update.php: FAILED. Seems PostgreSQL schema don't handle change field correctly.
  • INSERT: FAILED. Seems db_insert() of PostgreSQL don't handle correctly.
CommentFileSizeAuthor
#6 dbtng-watchdog-variables-1226570535.patch2.75 KBhswong3i
#4 dbtng-watchdog-variables-1225359310.patch2.71 KBhswong3i
#3 dbtng-watchdog-variables-1223999640.patch4.23 KBhswong3i
#2 watchdog-variables-1223882705.patch4.32 KBhswong3i
#1 watchdog-variables-1223486709.patch4.19 KBhswong3i
watchdog-variables.patch4.72 KBhswong3i

Comments

hswong3i’s picture

hswong3i commented
StatusFileSize
new watchdog-variables-1223486709.patch4.19 KB

Update based on http://drupal.org/node/316095 founding. Revamp BLOB field with nullable.

Tested with MySQL and PostgreSQL. Stand alone simpletest, pass.

hswong3i’s picture

hswong3i commented
StatusFileSize
new watchdog-variables-1223882705.patch4.32 KB

Integrate with progress of http://drupal.org/node/319401.

Tested with MySQL and PostgreSQL, DBLog simpletest all pass.

hswong3i’s picture

hswong3i commented
Title: Remap field as BLOB: {watchdog}.variables » [DBTNG + BLOB]: remap {watchdog}.variables
StatusFileSize
new dbtng-watchdog-variables-1223999640.patch4.23 KB

Since #316095: Raise PHP requirement to 5.2.12 for PostgreSQL only already figure out the solution for PostgreSQL + BLOB + NULL + INSERT/UPDATE bug, this patch is now safe for using both null or nullable BLOB field.

Patch reroll via CVS HEAD. Only change field type from TEXT to BLOB.

P.S. Actually, I would like to add default value for "variables" as it is 'not null' => TRUE by default. But since MySQL will buggy with #300219: [DBTNG]: MySQL should remove TEXT/BLOB default value so I would like to wait and handle this with another issue.

hswong3i’s picture

hswong3i commented
StatusFileSize
new dbtng-watchdog-variables-1225359310.patch2.71 KB

According to commit of #300219: [DBTNG]: MySQL should remove TEXT/BLOB default value, patch reroll via CVS HEAD. Tested with MySQL's simpletest.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

hswong3i’s picture

hswong3i commented
Status: Needs work » Needs review
StatusFileSize
new dbtng-watchdog-variables-1226570535.patch2.75 KB

Ooops... dblog.install need update. Patch reroll and pass MySQL + simpletest.

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou commented
Status: Needs work » Needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

hswong3i’s picture

hswong3i commented
Status: Needs review » Closed (duplicate)

duplicate with #147947: [DBTNG + XDB] Replace some TEXT:BIG with BLOB