Images at end of content overlaps footnotes
lelutin - September 4, 2008 - 07:54
| Project: | Footnotes |
| Version: | 6.x-2.0 |
| Component: | Footnotes.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
In fact, everything that is of class "inline*" overlaps the footnotes.
to prevent the situation, add clear: both to "footnotes" class.
patch for footnotes.css attached to bug report.
| Attachment | Size |
|---|---|
| footnotes-6.x-2.0.patch | 22 bytes |
#1
Good catch, thanks.
Applied and committed, also did the same fix for "footnotes-alternative_layout.css". This fix is available in footnotes-6.x-2.1 and footnotes-5.x-2.1.
PS: Some technicalities...
- in creating patch you've had origfile and newfile the wrong way (patch command catches this though, no problems)
- use two spaces instead of tab
- in drupal, it is prefferred to us -Up as arguments to diff. (Unified diff style)
- even so, it was really nice to have someone posting a patch along with a bug report. It was a small thing and a small bug even, but even so, it made me feel nice. thanks!
#2
I saw those two problems right after committing, oops :\
didn't know about the -p option. it's pretty handy.
This one was my first bug report / patch submittal both to drupal and to open source projects alltogether, the feedback is much appreciated :)
heh, good idea. fixed my vimrc
#3
Drupal is my first significant Open Source participation too, I have to say it is a relatively good place to start. Welcome to the club!
#4
Automatically closed -- issue fixed for two weeks with no activity.