I have installed this module to ease creating lots of users. It is kind of helpful but does not appear to generate random passwords. It always sends the same password to every user. This would appear to be incorrect behaviour and opens a potential security hole.

I am looking at fixing it and will submit a patch if there isn't something already in the pipeline...

CommentFileSizeAuthor
#7 genpass-6--1.patch7 KBjapanitrat
#3 genpass-6--1.patch1.78 KBjapanitrat

Comments

abamarus’s picture

abamarus commented

Ahh... after a bit more digging into it I believe that the problem is the email is not substituting !password for the generated password. I have no idea how to fix this but it needs fixing for this module to be fully useful.

starbow’s picture

starbow commented

Yeah, it's not quite working at the moment. That is why I haven't done a release.

japanitrat’s picture

japanitrat commented
Status: Active » Postponed (maintainer needs more info)
StatusFileSize
new genpass-6--1.patch1.78 KB

problem is not related with the email-generation, its the form-generation.

try this patch on the d6 version

starbow’s picture

starbow commented
Status: Postponed (maintainer needs more info) » Needs review

The code looks good. I will test it out.
Thanks japanitrat.

abamarus’s picture

abamarus commented
Status: Needs review » Reviewed & tested by the community

I have tested this patch and it works. Problem solved - thanks japanitrat!

japanitrat’s picture

japanitrat commented

ouch, ive just seen that it will always generate a new password, even though there has been entered one (wrong conditional in genpass_register_validate2 I did not focus on). I've made a new patch, which applies to the original version.

thanks for testing

japanitrat’s picture

japanitrat commented
StatusFileSize
new genpass-6--1.patch7 KB

oh I forgot the actual patch. I also added some configuration stuff to /user/admin/settings like hiding the password fields for new user registrations and so on.

abamarus’s picture

abamarus commented

OK... that'll teach me to test more thoroughly!

I have applied the new patch and al apprear to be good. I like the new admin options - very useful.

Good work - this must almost be ready for a release!

starbow’s picture

starbow commented
Status: Reviewed & tested by the community » Fixed

@japanitrat: I finally got a chance to do some test - man what a great patch! I will release a beta. And if you get a CVS account and want to co-maintain this module, just let me know.

japanitrat’s picture

japanitrat commented

Hey starbow,

thank you for looking over it! I really appreciate your positive response and would be glad to be co-maintain this handy module. Since I don't have a CVS account yet, I'll take this issue to apply for one if you don't mind.

Thanks again :)

AjK’s picture

AjK commented

cvs account approved, feel free to add to the project.

starbow’s picture

starbow commented

@japanitrat: welcome aboard :)

japanitrat’s picture

japanitrat commented

yay! that was fast :D

j2g2’s picture

j2g2 commented

Hi, I just downloaded the genpass "genpass-6.x-1,0-bata1.tar.gz" module, installed, after created a user, it tell me a password generated, I was wonder if your patch is already incooperated into the module I downloaded? If not, how do I apply the patch to the module? I am new to this area.

Thank you so much for your help in advance.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.