Drupal 6.x port for "Golden Hour" Theme

I have no plans to port Golden Hour to D6.
If you (or anyone) submit an update / patch for D6 I will review it and post a D6 version.

Here is a patch to take Golden_hour from 2.2 to Drupal6. It works OK in my environment, and I've deployed a subtheme of it in production.

I've attached both a patch against 2.2 and a full version of the module.

Thanks for creating this in the first place! It has served me well.
-Randy

Update 2/17/09: See revised patch later in this thread

I tried out theme from golden_hour_d6.tgz archive. In my Drupal 6 setup clicking on menu and Read More Links throws an error "warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\includes\bootstrap.inc on line 761."

@andzs - I'll be happy to work on your problem, but I don't completely understand it yet, and was not able to re-create it based on what i understood.

Are you saying that when you click on the "read more" link in a teaser list, that you get the error you saw? You say "clicking on menu and read more links", but I can't figure out your path.

Please post with more details about your issue. You may also contact me directly by email here.

Here is the revised version of Golden Hour for Drupal 6 with the problem reported by andzs fixed. It was just a silly porting issue with the l() function.

Problem fixed.

I tested the revised version at http://d-theme.com/golden_hour. There is one thing to fix to achieve XHTML 1.0 Strict validation.
The following line contains a style attribute and the default style sheet language is not specified. The best approach is to put this width into a class and use the class in this line.
<div id="content" style="width: 72%;">

There is also a weird backtick at the end of the description in the .info file.

style.css produced the following validation errors.
199 Parse Error ----------node styles----------*/ .node { margin:0; padding:0; }
253 Parse Error ----------page styles----------*/ .page { margin:0; padding:0; }

icons.css produced the following validation error.
35 .comment .title Value Error : background-position middle is not a background-position value : 3px middle

With these items fixed, the theme will pass WCAG AA and some other tests.

This version of golden_hour validates as XHTML 1.0 Strict, and the CSS validates also. Let's get this committed!

@rfay - I looked over your update and here are some issues that need addressing:

• Drupal 6 themes now specify regions w/in the theme's .info file. You still have regions defined in template.php
• function golden_hour_get_primaryContent_width is totally unnecessary - this can be achieved with body classes & CSS
• function golden_hour_links will probably break certain modules like the Services Links module
• function golden_hour_menu_links is not needed anymore
• Icons can not be packaged with theme - the icons are not GPL and should be removed from the Drupal CVS repo
• What is contentpage.tpl.php ?
• What is <div id="forsimplemenu"></div> ?

Here is my take on this. I think that I have addressed most issues.

Minor fix.