Closed (fixed)
Project:
Drupal core
Version:
x.y.z
Component:
comment.module
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
9 Sep 2005 at 03:16 UTC
Updated:
1 Nov 2005 at 10:21 UTC
Jump to comment: Most recent file
- to reproduce
1) d0 a clean checkout of HEAD as of Thu Sep 8 20:10
2) created new/empty db to go with it
3) create a piece of content (story).
4) try to add a comment to that story
NOTE: you get the error: This discussion is closed: you can't post new comments.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | comment_hlslaughter20050919.module.patch | 905 bytes | harry slaughter |
Comments
Comment #1
harry slaughtersorry, that's 20:10 PDT
Comment #2
harry slaughterk, this bug seems to happen on my machine running php 5.0.4
but same setup on another machine is fine, it's running 4.3.10
Comment #3
harry slaughterthis is partially addressed in: http://drupal.org/node/31306
but with that patch, there's another bug in comments.module. i'm assumming it's probably fixed in some patch i don't have yet. i'll close this ticket when i see that things work again for myself.
Comment #4
michaelsb commentedThis sounds like the problem I ran into. Try this patch and see if it fixes your problem:
http://drupal.org/node/30354
Comment #5
harry slaughteri created a similar patch. but i think there's bad logic in the code. the edit[date] field is empty because the user is creating a comment, so there is no previous timestamp to make editable.
instead of setting the date, which should be getting set elsewhere, the code should be aware that the the user isn't able to edit a timestamp when the comment is created, and this data validation should not even take place.
but i definitely wouldn't be setting the value at this point in the code as your patch does.
Comment #6
harry slaughterattaching patch mentioned in last comment
Comment #7
harry slaughterComment #8
dries commentedThis should have been taken care of.