I am unsure if this is really a support request, a bug report, or a feature request!
When I toggle the Administration Menu using the key command, it works correctly. However, as soon as I go to another page on the site it reverts back to the default state. The expected behaviour for me would be that once it is put into a particular state with the modifier key, it should stay that way for the remainder of the session unless I change it.
If that should be happening, what could be going wrong? I had tried installing the jQuery update, and wonder if that is the problem, although I removed it without it correcting the problem. I see now the problem also exists on the live site which was never updated.
If this is not the intended behaviour, I would consider this a feature request!
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | admin_menu_dropdown-6.x-2.x-dev-307440-Maintain_visibility-1.patch | 4.01 KB | deciphered |
| #5 | admin_menu_dropdown.patch | 2.2 KB | babbage |
Comments
Comment #1
babbage commentedETA: Original browsers were Safari and Firefox for Mac but I have now confirmed this same behaviour in IE7 for Windows XP.
Comment #2
babbage commentedI have since deployed this module in Drupal 6.4 and the same behaviour occurs there. This is definitely a feature request and so I have assigned it as such.
Comment #3
babbage commented(Move to 6.x-2.x.)
Comment #4
decipheredHi dbabbage,
Sorry I didn't get back to you sooner but I have been on holidays.
You where correct to re-tag this as a feature request, as what is happening at the moment is the default behavior.
However, it is a very good feature request and I will certainly look into implementing it.
Cheers,
Deciphered.
Comment #5
babbage commentedThis proved to be trivially easy for me to implement, when I actually looked into how to do this, as while it is more complicated to read a cookie in javascript it is trivially easy to set one, and it is easy to read it from PHP on page load. I have also updated the admin interface help text and description of the default preference to indicate they are now for the start of a session, after which any changes the user makes to visibility will be honoured.
I'm so glad I did this. It's going to improve my quality of life. It's the little things! :)
Updated title to reflect current status.
Comment #6
babbage commentedNote for anyone like me who has not lived and breathed patch that this patches js files in a subdirectory of behavior so needs to be applied using:
patch -p0 < admin_menu_dropdown.patch(Is there any way to set up a single patch file that can avoid users needing to include the -p0, by the way?)
Comment #7
babbage commentedNote the patch in #5 only maintains visibility settings through a session if you are using key commands to show and hide the menu, not if you have it collapsing to a clickable icon in the corner. It appears the structure of that part of the code is significantly different, so applying the same changes in that js file did not result in the behaviour I initially expected. I'm happy to have a look at that potentially but think the current patch stands on its own still...
Comment #8
decipheredHi dbabbage,
Admittedly I haven't paid much attention to this module of late, but I will absolutely look at this patch and if I'm happy with it roll it in.
Thanks for the good work.
Comment #9
decipheredHi dbabbage,
As terrible as this sounds, I actually did write this feature in soon after you made this request, I just never finished it.
I have opted to finish my original code instead of using your patch. The major difference is that my version uses the PHP Session instead of a cookie, and it also has support for the Icon hotspot mode.
Attached is a patch as I don't currently have access to CVS where I am. Will submit to HEAD ASAP.
Comment #10
decipheredCommitted to DRUPAL-6--2
Comment #11
babbage commentedAh well... at least it is implemented now. :)
Comment #12
deciphered