Here is a patch which fixes most of them.

They were mostly issues like "string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms" and constants being in lower case FALSE, TRUE, NULL etc... There are a few i didn't fix like "global variables should start with a single underscore followed by the module and another underscore" and "the use of REQUEST_URI is prone to XSS exploits and does not work on IIS; use request_uri() instead" as i was un-sure what other things it may affect. So it may be worth while for someone more familiar with the inner workings of the module to give it a once over.

Note : this patch is untested.

CommentFileSizeAuthor
provision_coder.patch50.94 KBa_c_m

Comments

adrian’s picture

adrian commented
Status: Active » Fixed

Thanks for the patch. I've committed an updated version.

The request_uri() is a lame duck, since we are SETTING the uri, not returning it, and we only work on unix based systems.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

  • Commit a7cfa91 on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_716166_apache_conf, dev_dns, dev_server_verify, prod-koumbit, ssl, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by adrian: 
    #308255 - cleaned up a bunch of coder warnings