I'd like to help out with the translated English of this module. How can I do that?

CommentFileSizeAuthor
#3 photos.pot16.41 KBdydecker

Comments

yang_yi_cn’s picture

yang_yi_cn commented

I think you can just post the .po file here and the maintainer will look at it

eastcn’s picture

eastcn commented

thank you.
You can fix the string, and then submitted to here.
pot file: photos\translations\photos.pot

dydecker’s picture

dydecker commented
StatusFileSize
new photos.pot16.41 KB

Attached is a rewrite of the .po file. 95% ok I think - a couple of minor strings I couldn't find on front end.

Regarding the name of module, maybe "album photos" is a little unnatural in English. The best choice would be "Photo Albums", but perhaps that is very similar to an older (disused) Drupal module called "Photo Album". But since that module is not available anymore, maybe you can use it?

Or you could give the module its own unique name. I think "Pix" might be a good name. Short, sweet, and different from other modules.

I did not change "album photos" in .pot file, but I can do if you want. Let me know what you think.

I renamed all instances of "images" to "photos" in the module for consistency, and to avoid confusion with other image modules.

Regarding plurals, I put "This album contains x photo(s)" so it works for 1. I'm not sure if you want to code to make an exception for 1, but maybe this will do for now.

eastcn’s picture

eastcn commented

Thank you for your work, I will make the amendment.
On the module name change, which will cause a lot of trouble.

gregzenger’s picture

gregzenger commented

Regarding plurals, "This album contains x photo(s)" so it works for 1....

I would rather it say "This album contains x photos." My reasoning is: how often do you have albums with only 1 picture? Sure, it can happen, but most of the time that wont be the case. And I don't personally have a problem with it saying "This album contains 1 photos." Of course, the proper way to handle this (eventually) would be to have an IF...ELSE statement to select the pluralized version. I dont know how this would affect the other languages though.

Just my 2 cents.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Drupal provides a easy way to provide an alternative for those cases, you can just specify two different translations...

http://api.drupal.org/api/function/format_plural/6

(But of course, the code needs to be changed... but this is necessary anywhay when a text is changed)

anoopjohn’s picture

anoopjohn commented
Title: English translation » Mistakes in the English translation
Component: Documentation » Code
Category: task » bug

This is a fantastic module and I think this is by far the best photo gallery module available in Drupal. However there seems to be quite a lot of grammatical mistakes in the labels and messages displayed in the module(for english). I am planning to put some effort into cleaning this issue up. Since the module has a few translations up and going it is not just a matter of editing the .pot file or the code, either of which if done alone is in fact incorrect.

The correct way to tackle the issue would be as follows

1) Find the text strings that need correction inside the code.
2) Find the corresponding msgids in the different .po files
3) Replace the incorrect string inside the code as well as in the .po files.

If we replace the text string from inside the code alone the corresponding translations will cease to work.

If eastcn could show me a green flag I could go ahead and work on this.

anoopjohn’s picture

anoopjohn commented
Title: Mistakes in the English translation » Grammatical and structural mistakes in the English translation

Others who stumble upon this thread please post issues/mistakes that you identify and their solutions here.

anoopjohn’s picture

anoopjohn commented

Is anybody looking at the issue queue. All I want is a confirmation that my effort is not going to be wasted.

Starminder’s picture

Starminder commented

Subscribe - I opened a similar ticket awhile back. Am also more than happy to help.

Is anyone actively working on this module anymore?

nathaniel’s picture

nathaniel commented
Version: 6.x-2.0-rc4 » 7.x-3.x-dev
Assigned: Unassigned » nathaniel
Category: bug » task
anoopjohn’s picture

anoopjohn commented
Issue summary: View changes

Is this issue still relevant?

nathaniel’s picture

nathaniel commented
Assigned: nathaniel » Unassigned
Status: Active » Closed (outdated)

I guess not.

We can open a new issue if needed.