Require revision log entry on d.o handbooks

a) many people don't even think about it and would use it if they were reminded

I think part of this problem is that there is no continuity between the naming of the log box and the revision changes. While the filedset in D7 helps with this, I think if it were named and described better, that would help part of this issue. To that end, I've submitted this patch: http://drupal.org/node/308774. Obviously, it won't help totally forgetting about it when you know what it's there for.

Good suggestions. I'd be happy to review, commit and deploy such a patch to drupalorg.module.

The patch to drupalorg.module will have to wait until the issues to http://drupal.org/node/308352 are corrected.

Also, I've just created a not-nearly-as-important patch that might also be nice to include: http://drupal.org/node/308820

I think oadaeh's point is that the logic regarding when to make the field required is still being sorted out. add1sun is right that we don't have to wait for the core patch to land to roll out this feature on d.o, but we might as well get the logic right. ;)

Just noting that http://drupal.org/node/109197 seems to be the same request.

Here's my initial stab at this. Having never actually modified drupal.org code itself, I'm sure I've probably done something wrong. Also, it seemed like it was less simple than it should have been, but I couldn't find a better way to do it.

The attached patch changes the wording based on my proposal, so if you don't want that, just say so.

It should require a log message for all node editing pages that have the 'Create new revision' checkbox checked. It should display(but not require) the form for all other node editing pages where the user has the ability to change that option. It should not display it if neither of those are true. It should also not be displayed on any node adding page.

Hmm, are we having a problem attaching files again? I know I added it on my previous comment.

So, really all you want is something like this:

  elseif ($form_id == 'book_node_form') {
    if (($node_revision || user_access('administer nodes')) && arg(1) != 'add') {
      $form['log']['#required'] = TRUE;
    }
  }

I was just trying to be complete and cover all the bases.

That'd probably work. I was thinking of something even more simple, like this:

    elseif ($form_id == 'book_node_form' && isset($form['log'])) {
      $form['log']['#required'] = TRUE;
    }

Untested, but I think that's all we need.

Here's the updated patch.

Reviewed, tested, committed, and deployed on d.o. Thanks oadaeh and add1sun. Enjoy. ;)

Oh, does this ever suck!

Could we remove this for people with certain perms ;-) Seriously, I do a lot of editing and having to log every time drives me nuts.

Kieran

I'd love to get this feature into core for D7. #308352: Allow revision log messages to be required if you wanna help. :)

Per discussion with webchick on IRC, this needs to be changed to not require logging on preview.

Michelle

I'm not 100% sure how to do that easily with FAPI, and I don't have time in the near future to think about it enough to deal with it.
If this "needs to be changed" someone else should roll a patch for it.

Honestly, I don't see how this is a UX improvement -- you're going to need the log message eventually, why not just fill it in? If you're creating a new page and you just enter a body but no title and hit preview, you get a validation error about title being required and don't see the preview of your body text, either. How/why is this any different?

If it's a pain to change, then I guess just leave it. It just came up on IRC along these lines:

addi: required logs Yay!
me: error messages on preview *grumble*
webchick: bug file issue

So if I'm the only one it's bugging and I'm not putting any code out there I'm fine with just setting this back to fixed unless webchick thinks it needs to be fixed further.

Michelle

It's a pain, but I am living with it. Addi, can you assign this issue to yourself.

Kieran