As a way to familiarize myself with this module before porting it to Drupal 6 I went through the code and made some coding style type changes. I hope you'll find it worthwhile to review, and consider committing, this patch. Would be nice to get this done before starting work on the port.

  • Replaced tabs with spaces.
  • Removed "unused" spaces (that is, multiple spaces that are the last characters on a specific line).
  • Ran coder.module and corrected a few coding standard issues.
  • Went through the function documentation and made some changes to conform to the coding standards. Removed @params from standard Drupal hooks, standardized @param descriptions, etc.

Attaching two patches: one is the full patch, the other one ignores whitespace, which makes it easier to read and review, hopefully.

CommentFileSizeAuthor
#2 ffmpeg_wrapper-308760-coding_style.patch2.78 KBzoo33
ffmpeg_wrapper-coding_style-no_whitespace.patch15.84 KBzoo33
ffmpeg_wrapper-coding_style.patch34.45 KBzoo33

Comments

arthurf’s picture

arthurf commented

I applied this against the D5 branch but it wasn't clean. I'm not sure if it is a version miss-match or not, but I've kept what worked for now. This is committed to D5 now, thanks for the patch.

zoo33’s picture

zoo33 commented
StatusFileSize
new ffmpeg_wrapper-308760-coding_style.patch2.78 KB

Here's another patch with a few remaining fixes that didn't get in. Not sure it's everything though.

Will have another go with whitespace changes once this is in.

zoo33’s picture

zoo33 commented
Status: Needs review » Reviewed & tested by the community

I went ahead and committed a ported version of the above to D6. I suggest we commit this to D5 too.