Hi,

First release of a simple refactoring for the add users page, you can find a screenshot and the alpha code.

I've replaced the textarea with 2 multiple transfer select (jquery + livejquery (require jquery_update for this)), With the standard Add Remove buttons + (only with livejquery) doubleclicking for add remove on items.

I'm here for your feedback

Cheers

CommentFileSizeAuthor
#14 og_username_helper.jpg11.59 KBgustav
#14 og_username_helper_inaction.jpg16.92 KBgustav
og_add_users_ng.zip2.92 KBpaolomainardi
add_users_form.png33.02 KBpaolomainardi

Comments

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Needs work

I'm so so on the UI. The code needs a lot of work still. It duplicates to much of OG. I gues yu had to by doing it as a module instead of a patch. Also, I would really target D6 version instead of D5.

paolomainardi’s picture

paolomainardi commented

Hi Moshe,

It's already a module, i'm working on D5, so i've writed it for D5 and og 7.3, we don't have code duplication (only the submit and validate are similar).

What don't you like for the UI ? (Please, here we have only a textarea by default..)

Ciao ;)

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

My biggest problem with this feature's concept is that we don't always want group admins to see all the name of the users in the site.

Regarding the UI, If we're already using jQuery then maybe an autocomplete feature is better, which is better supported in core.

paolomainardi’s picture

paolomainardi commented

This plugin is using, native Drupal Jquery nothing more...then the autocomplete features or the textarea, how avoid the problems to see/add random site users ?

Or, we can add a Permission "Advanced add users interface" (or similar) for this nicer interface.

What do you think ?

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Maybe this:

1. Keep the textarea - it's good for copy/ paste.
2. If user has 'access user profiles' permission then show also an auto-complete textfield (i.e. you will be able to enter the users one by one).

I think this answers:
* The need of adding users in a more friendly way
* Not showing all the site users to users who shouldn't see it
* The need to keep stuff simple and 'Drupaly'.

paolomainardi’s picture

paolomainardi commented

Ok, i understand that this kind of interface it's not an OG business :)

But, really i don't understand why we can't see the users, if then we can add what we want and at the end only the group manager can see this, for example with another permission, because all the users in a community have "access user profiles" permission.

Or, can be only an "admin" interface for mass user inserting in custom OG.

So anyway, thank you for your feedback :)

Paolo

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

because all the users in a community have "access user profiles" permission.

This assumption is incorrect.

scedwar’s picture

scedwar commented

"really i don't understand why we can't see the users"

Here is a real case study for why this is bad.

We use og to manage teams on our charity site. The members of a group are the team supporters. The admins of the group are the team members. The group analogy works great. However, if we opened up the possiblity for an over zealous team to add every user on the site as a group member (i.e. a supporter) we would very quickly lose users...

Think of it as if you were on facebook, and you were able to see a list of every facebook user and add them as a friend...

Stephen

paolomainardi’s picture

paolomainardi commented

But we can have the possibility of mass inserting users from "super admin" and this interface can be really useful, at least in this case (my case).

Paolo

scedwar’s picture

scedwar commented

I see. In which case, some filters for the list of users would really make that useful. For example, filter by group members of existing groups, or profile fields, or roles etc.

paolomainardi’s picture

paolomainardi commented

Adding the filters in this interface ?

alb’s picture

alb commented

other:
not tested your patch, but a bug of add member is that is possible
insert in a group also the site's superadmin.

alb’s picture

alb commented

bugs:
if I have already some members in a group, when use your modules I not see in second box the members that already I have;

if I want insert a member in a group,I click on add, I see on the 2nd box but when click on Submit all
is cleared ;
so for me module not work.

gustav’s picture

gustav commented
StatusFileSize
new og_username_helper_inaction.jpg16.92 KB
new og_username_helper.jpg11.59 KB

Just in case some followers of this thread might be interested: the is a patch, created by marvil07, that simply adds an autocomplete username field to the user add form, see http://drupal.org/node/225308. If you know the beginning of the usernames of the users that you want to add then that autocomplete field can be a very convenient tool. I have attached screenshots.

alesr’s picture

alesr commented

Is this Improved OG Add users form available on D6?

angelmax’s picture

angelmax commented

I am interested in having this functtion for og 6.x.
Thanks

mrfelton’s picture

mrfelton commented

Also looking for this for D6

hansrossel’s picture

hansrossel commented

For D6 there is http://drupal.org/project/og_username_helper

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

This version of Drupal is not supported anymore. If this is still an issue in the 8.x-1.x branch, please open a new up-to-date ticket. Closing.