When a conflicts occurs and the script show two ways to resolve them, it shows a wrong parameter to the user in the following line:

./dbscripts/restore.php production min <strong>sequences</strong>

Would not be the TRUE boolean? I think this bug is too small to create a patch.

Comments

ceardach’s picture

ceardach commented
Assigned: Unassigned » ceardach
Status: Active » Closed (works as designed)

The string "sequences" becomes translated to "TRUE" in lines 60-63 of dbscripts.module in the dbscripts_get_options() function.

I did it that way so that it makes more sense what that flag is setting when entering the command.

Anonymous’s picture

Anonymous (not verified) commented

When I try with the strings, the help text appears instead of processing the restore operation. I will try again and send a screenshot.

ceardach’s picture

ceardach commented

Yeah, I've seen that bug. I thought I fixed it, but apparently not. I'm working on it now.

restore.php production min works
restore.php production min help works
restore.php production min blah works (successfully ignores 'blah')
restore.php production min sequences spits out help text... dunno why.

I'm looking at it, though.

ceardach’s picture

ceardach commented
Title: Wrong parameter displayed when a conflict occurs » 'production min sequences' spits out help text
Status: Closed (works as designed) » Active
ceardach’s picture

ceardach commented
Status: Active » Fixed

I have no idea why this was happening. So, instead of fixing the problem, I just avoided it.

I pulled serving help text out of each action's function, and instead decide whether or not to serve help text through the executables (restore.php, etc).

Should be included in the next rebuild.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.