Posted by hass on September 19, 2008 at 7:01pm
| Project: | Internationalization |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This patch fixes numerous bugs in translatable strings. For e.g.
1. Many missing periods.
2. Missing format_plural()'s.
3. Fixes many context sensitive translation issues.
4. Changes wording on links to i18n handbook like core.
5. Fixes on broken link to i18n handbook (help page of i18nsync module).
6. Fixes code style on a few translatable strings.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| D6_i18n_translatable_string_fixes.patch | 23.43 KB | Ignored: Check issue status. | None | None |
Comments
#1
And not to forget... please take a look to
i18ntaxonomy_term_pagefunction. There are a few variables that seems not t'ified!? But I'm not sure if this is not done somewhere else... so - unverified.The potential lines are:
drupal_set_title($title)$breadcrumb[] = l($current->name, 'taxonomy/term/'. $current->tid);
drupal_add_feed(url('taxonomy/term/'. $str_tids .'/'. $depth .'/feed'), 'RSS - '. $title);
#2
Marking critical for release
#3
Committed. I've been doing some renaming after that.
About the taxonomy_term page function, these are user defined strings (mostly term names) so they're not supossed to go through t()
Thank you!
#4
THX, change what you need to change, but follow the translation rules to become a good example, please. :-)
#5
@Jose: Please keep the following in mind:
Don't do this, *never*:
$output .= '<p>' . t('To search and translate strings, use the !translate-interface pages.', array('!translate-interface' => l(t('Translate interface'), 'admin/build/translate'))) . '</p>';Correct:
$output .= '<p>' . t('To search and translate strings, use the <a href="@translate-interface">translate interface</a> pages.', array('@translate-interface' => url('admin/build/translate'))) . '</p>';And please don't forget to add periods to sentences. Your commit http://drupal.org/cvs?commit=142300 needs work.
#6
Here is a new patch for the latest code to fix the new bugs.
#7
Thanks again!
I think you could just commit into the module if you find any other issue... however I bet you prefer me to review the patches before committing them myself, for 'educational' purposes :-)
So, yes:
- I will follow the localization guidelines.
- I will follow the localization guidelines.
- I will...
Really, thanks for the heads-up, I was not up to date with that ones...
#8
thx, ok :-)
#9
Automatically closed -- issue fixed for two weeks with no activity.