This patch fixes numerous bugs in translatable strings. For e.g.

1. Many missing periods.
2. Missing format_plural()'s.
3. Fixes many context sensitive translation issues.
4. Changes wording on links to i18n handbook like core.
5. Fixes on broken link to i18n handbook (help page of i18nsync module).
6. Fixes code style on a few translatable strings.

CommentFileSizeAuthor
#6 D6_i18n_more_translatable_string_fixes_2008092501.patch12.57 KBhass
D6_i18n_translatable_string_fixes.patch23.43 KBhass

Comments

hass’s picture

hass commented

And not to forget... please take a look to i18ntaxonomy_term_page function. There are a few variables that seems not t'ified!? But I'm not sure if this is not done somewhere else... so - unverified.

The potential lines are:

drupal_set_title($title)
$breadcrumb[] = l($current->name, 'taxonomy/term/'. $current->tid);
drupal_add_feed(url('taxonomy/term/'. $str_tids .'/'. $depth .'/feed'), 'RSS - '. $title);
hass’s picture

hass commented
Priority: Normal » Critical

Marking critical for release

jose reyero’s picture

jose reyero commented
Status: Needs review » Fixed

Committed. I've been doing some renaming after that.

About the taxonomy_term page function, these are user defined strings (mostly term names) so they're not supossed to go through t()

Thank you!

hass’s picture

hass commented

THX, change what you need to change, but follow the translation rules to become a good example, please. :-)

hass’s picture

hass commented
Status: Needs review » Active

@Jose: Please keep the following in mind:

Don't do this, *never*:

$output .= '<p>' . t('To search and translate strings, use the !translate-interface pages.', array('!translate-interface' => l(t('Translate interface'), 'admin/build/translate'))) . '</p>';

Correct:

$output .= '<p>' . t('To search and translate strings, use the <a href="@translate-interface">translate interface</a> pages.', array('@translate-interface' => url('admin/build/translate'))) . '</p>';

And please don't forget to add periods to sentences. Your commit http://drupal.org/cvs?commit=142300 needs work.

hass’s picture

hass commented
Status: Fixed » Needs review
StatusFileSize
new D6_i18n_more_translatable_string_fixes_2008092501.patch12.57 KB

Here is a new patch for the latest code to fix the new bugs.

jose reyero’s picture

jose reyero commented
Status: Active » Fixed

Thanks again!

I think you could just commit into the module if you find any other issue... however I bet you prefer me to review the patches before committing them myself, for 'educational' purposes :-)

So, yes:
- I will follow the localization guidelines.
- I will follow the localization guidelines.
- I will...

Really, thanks for the heads-up, I was not up to date with that ones...

hass’s picture

hass commented

thx, ok :-)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.