this is a great module but i think there's something need to improve.

first, it would be better if save the photo as node, that will bring the power of drupal's node system such as taxonomy, cck etc to the photo and made it extremely extendable. and it'll also reduce the duplicate functions such as voting and comment in your module right now.

second, the codes right now is really mass. we need to split the codes into some contribute modules. for example, "photo quote", "photo swf_upload", "album", this will clean the codes, made it more drupal style and also bring the perfermance improved. you can take a look at module image_fupload. it's a good example.

third, the words used in your modules made me confused. you use 'album', 'photos' and 'image' in one module, that's a bad idea. how about 'album' and 'photo'? the menu items also need to be reorganized, i think.

fourth, your module is very similar with module gallerix......

lastly, please read this, http://www.scribd.com/doc/3110492/Ajaximggallery, i think it describes clearly what an ideal gallery module should be. you're on the right way, good luck!

Comments

nathaniel’s picture

Status: Active » Closed (works as designed)