Posted by ncd on September 23, 2008 at 9:58am
| Project: | CurvyCorners |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Is there anyone who can add Drupal 6.x support for this module?
With the current version all we get is: "This version is incompatible with the 6.4 version of Drupal core."
Comments
#1
I have ported this as best as I can to Drupal 6.
I had to change the function names and file names to be compliant with the coding standards, so this patch may not work. If not, just remove all:
curvyCorner.*
files that have a matching:
curvy_corner.*
name.
Just a note, autoPad option seems to break Drupal's javascript, so it seems to need to not use that.
If someone is better (meaning more experienced) with cvsdo add, and cvs diff, I will gladly send you the files and you can create a cleaner patch (if this one doesn't work).
Thanks,
Pat (CrashTest_)
#2
OK, thank you. I will try this out....
Although, how exactly do you apply the patch?
#3
ncd - do you still need instructions on how to apply the patch? if so, i recommend reading http://drupal.org/node/60108 and http://drupal.org/node/60179 (i used UnxUtils, see http://drupal.org/node/60182, and it worked just fine)
#4
good news!
i have tried the patch in #1, and it seems to work on Drupal 6.10, at least according to some very basic tests on IE7 and Firefox 3.0.8 (both running on XP)
one little twist though... i used version 1.2.10 instead of 1.2.9 of CurvyCorners (see http://www.curvycorners.net/downloads.php) and the filenames have changed... you will need to find the code in curvy_corners.module where the javascript files are referenced (two different files, lite and full, which doesn't seem to apply anymore in 1.2.10) and change the names of the files:
- $path = drupal_get_path('module', 'curvy_corners') .'/rounded_corners.inc.js';
+ $path = drupal_get_path('module', 'curvy_corners') .'/curvycorners.js';
- $path = drupal_get_path('module', 'curvy_corners') .'/rounded_corners_lite.inc.js';
+ $path = drupal_get_path('module', 'curvy_corners') .'/curvycorners.js';
(if you change them both, the "lite" setting in the admin page admin/settings/curvy_corners will probably be totally irrelevant)
otherwise, all instructions in the README_D6 file (and #1 above), if followed closely, should give you positive results.
thanks CrashTest, this rocks!
cheers
Fish
#5
See also the jQuery Eye Candy module which supports the JQuery plug-ins:
Additional search engine keywords: curvey curveyCorners
#6
subscribing... for whenever/if-ever this project is active again.
#7
@klonos - last time i tried CurvyCorners it didn't work... but that's because i forgot that i went through all this in Apr 2009 (see above)... if you implement the patches there (see my comment #4), it should work!
so this project is "active" in the sense that it works! though until the maintainer adds those patches, that must be done by hand...
cheers
Fish
#8
I see what you mean Peter and thanx for letting us know that it does work with the patches applied. I was looking for a D6 solution though and there isn't even a dev version around. The project maintainer has not committed anything in 3 years! Those two facts pretty much qualify it as an inactive project.
PS: I'll try and pack an 'unofficial' 6.x version (the 5.x dev with the patch from #1 + the changes in #4) and upload it here for everyone's convenience.
... unless someone else beats me to it ;)
#9
here it is...
Note: I have not tested this myself! I've simply put together the patch in #1 and applied the changes in #4. So, provided with no guaranty whatsoever - use at own risk.
#10
thanks klonos, that should help out a few people!
next time i have a chance, i'll check your download myself and make sure... but if you applied the patch correctly, it should work, because that's all i did, when i looked at this a year ago, i don't think i had to fix any bugs or anything
cheers
Fish
#11
6.x module has been released with a few minor updates and upgraded support for CurvyCorners 2.0.4
Would everyone be interested in a 7.x release as well? The latest CurvyCorners 2.x has some cool features and runs great. This module is much lighter than a jQuery plugin running through a plugin manager....
#12
re: #11... yay! thanks JStarcher! are you a new maintainer, or are you just reporting on this breakthrough?
cheers
Fish
#13
Thank you Jordan! Not only a 6.x version, but also an added bonus!! ;)
I will be checking both 6.x and the 7.x out in the next couple of weeks and will report back.
PS: Not really important right now (since this is fixed and all), but I am changing the version to the proper one.
#14
Automatically closed -- issue fixed for 2 weeks with no activity.