Hi,

CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this work is a coding standards review of internationalization handling of strings. Attached you will find a patch based on a review with the coder module and a careful examination of the code. Thanks!

The majority of the changes fall into two categories:
* messages given to watchdog() and format_plural() should have t() calls wrapped around them as these functions call t() themselves.
* strings passed to t() should not have leading or trailing spaces as it makes it difficult for translators to accurately translate them.

Cheers,
Stella

CommentFileSizeAuthor
date_i18n.patch7.23 KBstella

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Applies cleanly, and all the changes look good to me.

karens’s picture

karens commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks! I went ahead and made the same changes in the D5 version, too.

stella’s picture

stella commented
Status: Fixed » Active

Looks like only the changes to date_repeat.module were committed for the DRUPAL-6--2 branch. All 3 modified files were committed for the D5 branch though.

stella’s picture

stella commented
Status: Active » Reviewed & tested by the community
karens’s picture

karens commented
Status: Reviewed & tested by the community » Fixed

Doh! Not sure how I managed to do that. Just tried again. Thanks!

stella’s picture

stella commented

Thanks!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.