If one empties the "Items to replace with Flir generated text" field in admin/settings/flir, we end up with something like $("").css("font-family","puritan_regular").each( function() { FLIR.replace(this); });, which messes up the whole page. This patch makes FLIR do nothing when the selector is empty. However, FLIR's JS is still added, in case one prefers to add his own text replacement logic.

CommentFileSizeAuthor
flir-empty-selector.patch1.23 KBDavid Lesieur

Comments

David Lesieur’s picture

Status: Needs work » Needs review
btopro’s picture

Status: Needs review » Fixed

Yeah I recently had to patch out internal code base for this glitch as someone "turned it off" without really turning off flir and it took the whole site offline. That'll definitely be in the next version and hopefully I can roll it in in a week or so (presentation tues I gotta prep for).

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.