Using 6.x-1.x-dev version, I cannot display more than 10 elements per timeline.
Here's a working example with a timeline and a list, both set to "Items to display: 0" (unlimited).
I attach the two admin views screenshots.
| Comment | File | Size | Author |
|---|---|---|---|
| timeline_unlimited_list.jpg | 53.86 KB | chirale | |
| timeline_unlimited_timeline.jpg | 52.26 KB | chirale |
Comments
Comment #1
chirale commentedMaybe modules like Calendar faced similar issues to display all elements instead default 10. The error is probably on that limit value, since when sort criteria change, it shows 10 different items.
It seems that timeline cannot read or set items_per_page values, so it fallback to default value. Calendar uses more code, and I see that "Not sure this should be here" on timeline.views.inc. Maybe including
plugins/views_plugin_style.incis not the right way to use views plugins? I try to copy some calendar code, with no success, but it could be useful to see other similar Views 2 modules to try to fix this error.Comment #2
chirale commentedSet to critical, since timeline view can only display 10 elements.
Update: style handler seems fake (calling himself), probably there's something wrong on that require_once. A Views 2 guru is warmly welcome here, I try to move
class timeline_views_plugin extends views_plugin_styleto include/views_plugin_style_timeline.inc and to changeto:'handler' => 'timeline_views_plugin'(code adapded from a patched tagadelic views module)
but without effects. At last, number of items setting in this view module is broken.
Comment #3
jmiccolis commentedchirale,
I've moved the timeline_views_plugin class definition into a new file where views expects it, so that extra include is gone. Also, I've added some additional logic to for views to respect pager and limit settings which should work for the time being.
I'm not totally happy with this code still, but this should fix the reported bug. (views 2 gurus are certainly still welcome to point out a better way!) Please set to fixed it works for you.
Comment #4
chirale commentedThanks Jeff, I've installed latest dev version (20081013) and now the example above starts to work. Even the pager works (just dreaming about a date pager :) ). Instead, I noted a little problem with entities. "Girl's High" on timeline appears as "Girl's High", with apostrophe as HTML entity, it'll be wonderful fixing it on this or on the next dev release. I continue testing during next days, thanks again for the quick fix!
Comment #5
spython commentedHm, I have the same problem with timeline on drupal 5.11, only showing the first 10 elements. The "Nodes per Block" setting doesn't seem to work. Is there anything I can change to make it work?
Comment #6
spython commentedOh, found it by myself - it turns out that "Nodes per Block" doesn't influence anything, you have to enable the page view, and there you can change how many nodes per page are shown. The same amount is then set for nodes per Block.
Sorry for the offtopic here.
Comment #7
jmiccolis commented@chirale,
I've moved the entity issue to it's own ticket http://drupal.org/node/322073 and am closing this one. Thanks for reporting it.
Comment #8
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.