From Chirale here: http://drupal.org/node/314158#comment-1057811

Instead, I noted a little problem with entities. "Girl's High" on timeline appears as "Girl's High", with apostrophe as HTML entity, it'll be wonderful fixing it on this or on the next dev release. I continue testing during next days, thanks again for the quick fix!

CommentFileSizeAuthor
#5 Picture 9.png20.25 KBcglusky
#4 Picture 8.png20.57 KBcglusky
#3 Picture 4.png15.72 KBjmiccolis
#1 timeline_decodentity_quotes.patch601 byteschirale

Comments

chirale’s picture

chirale commented
Status: Active » Needs review
StatusFileSize
new timeline_decodentity_quotes.patch601 bytes

This quick fix transforms single and double quote entities on title into right characters using html_entity_decode() function. I don't know if this is the right place to put it or if a best function should be used, but it seems to work fine.

cglusky’s picture

cglusky commented

Do we want to use PHP's html_entity_decode or Drupal's decode_entities?

http://api.drupal.org/api/function/decode_entities

I looked around and have seen it done both ways in other contribs.

Some work going into D7 core for decode_entities http://drupal.org/node/212130

c

jmiccolis’s picture

jmiccolis commented
Status: Needs review » Needs work
StatusFileSize
new Picture 4.png15.72 KB

I'm suspicious that this is actually an issue in the simile timeline code and not our module. Attached is an image where you can see that it renders the url-encoded title fine on the timeline itself, but just not in the popup.

Does this happen for the others that have seen this issue as well?

cglusky’s picture

cglusky commented
StatusFileSize
new Picture 8.png20.57 KB

I added an apostrophe to one of my feedapi items titles and was able to duplicate chirale's issue.

cglusky’s picture

cglusky commented
StatusFileSize
new Picture 9.png20.25 KB

And with patch from #1 applied it's fixed - in the timeline and pop-up.

jmiccolis’s picture

jmiccolis commented
Status: Needs work » Fixed

Ok, I've committed patch above with some minor changes, and added a comment. It seems unusual that we need to decode just one element that we send to the timeline widget - but it certainly fixes the reported issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.