Closed (fixed)
Project:
Fivestar
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Sep 2008 at 10:37 UTC
Updated:
14 Jul 2012 at 23:14 UTC
Hi,
CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this work is a coding standards review using the coder module. Attached you will find a patch for the problems found by the Coding and Commenting standards reviews.
Note, there were also three warnings thrown by the "interface text translatability" review which is provided by the potx module. None of these are fixed in the attached patch. For all three of the warnings, fivestar is using t() on a dynamic variable which is not what that function was designed for. You should consider using the tt() function provided by the i18nstrings module instead.
fivestar.module:
Line 1520: The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there.
Line 1525: The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there.
fivestar_color.inc
Line 205: The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there.
Cheers,
Stella
| Comment | File | Size | Author |
|---|---|---|---|
| fivestar_style.patch | 16.05 KB | stella |
Comments
Comment #1
stella commentedComment #2
catchThese are all whitespace spaces and some capitalisation, patch applies cleanly, so rtbc.
Comment #3
quicksketchThanks catch! If possible, could you submit D5 patches also? This one mostly applied but needed a little tweaking. Ported and committed.
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.