In D6, there's no need to specific access callback 'user_access' since that's assumed if no callback is given. Attached patch fixes those and also a couple of typos I noticed while I was in there.

CommentFileSizeAuthor
#1 fivestar_menu.patch1.53 KBcatch
fivestar_menu.patch2.39 KBcatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new fivestar_menu.patch1.53 KB

Only the menu fixes are valid in -dev, here they are alone.

stella’s picture

stella commented
Status: Needs review » Reviewed & tested by the community

These changes all look good and the patch applies cleanly. Marking RTBC.

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Closed (won't fix)

After the great menu scare of Drupal 6 I intentionally always specify the access callbacks. Any site out there still running Drupal 6.0 or 6.1 is still vulnerable to the access circumvention unless defaults are always specified. Plus, I think the code is simply more readable if the callback is always specified.