Posted by catch on September 30, 2008 at 12:46pm
3 followers
| Project: | Fivestar |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
In D6, there's no need to specific access callback 'user_access' since that's assumed if no callback is given. Attached patch fixes those and also a couple of typos I noticed while I was in there.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| fivestar_menu.patch | 2.39 KB | Ignored: Check issue status. | None | None |
Comments
#1
Only the menu fixes are valid in -dev, here they are alone.
#2
These changes all look good and the patch applies cleanly. Marking RTBC.
#3
After the great menu scare of Drupal 6 I intentionally always specify the access callbacks. Any site out there still running Drupal 6.0 or 6.1 is still vulnerable to the access circumvention unless defaults are always specified. Plus, I think the code is simply more readable if the callback is always specified.