Resizable setting is always enabled [#316200]

If I set resizable option to disabled on the edit vocabulary form (assume I use HS with taxonomy) then it stays resizable on the node submission page.
This patch handles the problem.
Explanation: in file hierarchical_select.js, in function Drupal.HierarchicalSelect.initialize there is an if statement which is always true: if (Drupal.settings.HierarchicalSelect.settings[hsid].resizable). That's because .resizable is string type. A simple parseInt solves the problem.
Diffed against 5.x-3.x-dev $Id: hierarchical_select.js,v 1.79 2008/09/21 22:25:44 wimleers Exp $

Comment	File	Size	Author
	resizable.patch	568 bytes	zserno

Comments

Comment #1

wim leers

Ghent 🇧🇪🇪🇺

commented 2 October 2008 at 15:29

Assigned:

Unassigned

» wim leers

Hrm, .resizable should NOT be a string. Thanks for reporting!

I'm sure that I did test if disabling the resizable option worked though, at least for Taxonomy. Where did this happen for you?

Comment #2

zserno commented 2 October 2008 at 16:40

Here is what I did:

Installed a clean 5.10
Installed HS 5.x-3.x-dev
Installed JQuery Update 2.0
Enabled modules: HS, HS Taxonomy, JQuery update
Status report shows no error
Set up a new category at admin/content/taxonomy/edit/vocabulary/1
Enabled HS for 'page' type, set resizable to disabled (btw here I had to hack a bit, because after I hit submit the HS settings are lost - see my other issue: http://drupal.org/node/316157)
Added some terms hierarchically
Visited node/add/page and HS is resizable (even though .resizable is "0")
In file hierarchical_select.js inserted the following line to line 22:
console.log("Type of .resizable: " + typeof(Drupal.settings.HierarchicalSelect.settings[hsid].resizable));