I am very happy to see a 6.x release of this module, but in testingit out I found it wasn't working right. Specifically,

1) on the shared posts page it was retrieving the wrong user's name for the page title
2) all shared posts were being listed under mine: whether they belonged to the user or if the user was an editor.
3) Edit: and View: item headings were not displayed.
4) All coherently accessible nodes were being listed on the editor's shared posts page, even when the editor was not assigned for some of the pages...

Looking through the code, I corrected the typos leading to these. Also, there seemed to be some confusion about the type of object being passed through the callback functions - ambiguity between a user object or a user id? Finally, it looked like one callback functions didn't have the right number of arguments.

Attached is a patch against 6.x-1.0, which seemed to be the most recent version. With these changes the module now seems to work as expected, but more testing is needed. Sorry if I misunderstood the intent of some of the coding or otherwise butchered it!

CommentFileSizeAuthor
coherent_access.module.patch4.1 KBMGN

Comments

MGN’s picture

MGN commented
Status: Active » Needs review

forgot to set the status on my earlier post....

jgraham’s picture

jgraham commented
Status: Needs review » Fixed

I've merged in most of these changes.

I'm still investigating some issues with the shared-posts page. But I think 1-3 in your original post have been fixed.

Thanks for the patch. Most of your adjustments were spot-on, I just made some minor adjustments.
Closing this issue. Hopefully I'll have a new release out this week. I have a few more fixes that need to go into the next release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.