Patch to support Nodeorder module, multi-taxonomy breadcrumb, and a pager module for image nodes

Unable to attach 2 files, so the Image Page pager module is attached here

Category and Status changed as I think 'feature request' and 'patch (code needs review) are more correct? Sorry, I'm new to trying to contribute stuff.

Image_page_pager module reuploaded (below) with amended README.TXT - no other changes.

Hmm. That happens if the image_page_pager1 (or2,3,4) function isn't picking up the $node $tid and $gallery variables. It's a problem I had at one point after putting the switch into the module to choose the pager type. I believed I'd fixed it as it's fine here. Anyone else seeing this?

Can you change the bit you placed in your theme's node-image.tpl.php (from the Readme.txt):

From:

<?php if (module_exists ('image_page_pager')) { ?>
        <div class="image_page_pager">
          <?php if ($page != 0 && $terms) {
          image_page_pager($node, $tid, $gallery);} ?>
          <?php } ?>
          </div>
        </div>

To:

<?php if (module_exists ('image_page_pager')) { ?>
        <div class="image_page_pager">
          <?php if ($page != 0 && $terms) {
          print image_page_pager_1($node->nid, $tid->tid, $gallery->name);} ?>
          <?php } ?>
          </div>
        </div>

This will bypass the switch and pager set in the admin settings and use pager_1 directly ... change the function to Image_page pager_2 (or 3 or 4) to use one of the other types.

Please let me know if that works.

BUT! the patch was against 5.x-1.x.dev Image_gallery so if you patched 1.9 anything is possible :-) The dev version has about 30 more lines in it, so d/l and patching that may be the first thing to try.

It would be very helpful to know what worked - patching the right version of Image_gallery, or bypassing the module switch in node-image.tpl.php? If the latter was necessary you have a workaround but it means something still isn't right with the module code.

tnt2000. As far as I can see, all you have done is add a few blank lines to image_gallery_module. But nobody has time to read through module code searching for differences.

Did you apply the patch manually? Or what? If so see http://drupal.org/node/14231 and if you're on Windows http://drupal.org/node/32875

All I can suggest is that you start again and see if it then works.

All is well - this is 'by design' (of Nodeorder), which is a general purpose module for ordering nodes of any type within a taxonomy term or vocabulary. It is a bit obscure in the docs for the module.

To set the order of your images go to http://mysite.com/admin/content/taxonomy/1/order (assuming 1 is the top level TID of your image vocabulary, else use whatever number it is) and you will be presented with a page listing all your galleries with 'set order' links alongside. Click on one of those and you'll be able to drag and drop the images into the order you want.

It's worth creating a menu entry for this, eg 'Order images' -> http://mysite.com/admin/content/taxonomy/1/order if it's something you'll be doing often.

Personally I find it much easier to set Nodeorder to 'Only show titles when ordering nodes' (via admin/settings/nodeorder). This gives a list of image titles instead of thumbnails when ordering nodes as above, which is much faster and easier to manage if you have a lot of images in a gallery. EG I have 76 in http://tonysleep.co.uk/frestonia - pressing Ctrl/- a few times reduces the font size so I can see all the titles on one screen at a time and setting the order was then a doddle.

Once you have set the order - and there is no 'save', just dragging the items around sets the order immediately - then your patched image_gallery should display them in the sequence you have set.

Sorry, I had to edit the above as I had used the Drupal 4.7 format http://mysite.com/admin/taxonomy/1/order. The correct Drupal 5.n link for ordering images is what it now says http://mysite.com/admin/content/taxonomy/1/order

@wentsch

Not a bad idea, I'd find that easier too :).

The attached additional patch to image_gallery.module adds a link to gallery pages for users to set the order of images within the gallery, provided :
- Nodeorder is installed
- they have access permissions to edit images & set image order
- the vocabulary is orderable.
Nothing happens or is displayed if any of those are untrue.

The link has a CSS class 'order_link' so can be tarted up.

Seems OK here, but please let me know.

I am sorry but I don't understand the objection. What's the specific problem? Support for Nodeorder being coded into Image_gallery?

Thanks for the explanation.

I'm aware Views supports Nodeorder. It does so via 'module_exists ('nodeorder')! via an inc file and selectable sort ordering. Might such a solution be acceptable for Image_gallery, so that different methods of ordering can be added via inc files?

[Re Viiews: I'm really reluctant to go that heavyweight route just to obtain what seem to me basic Image_gallery functionality. Everything addressed in this thread is a FAQ that has come up dozens of times. I don't know how a gallery module ever got released without a pager, a means to configure sort order, breadcrumbs that don't break when multi-taxonomies are used. These deficiencies have persisted ever since I began with Drupal 4.x, so hacking and patching is inevitable. That is a complete PITA I would like to try and solve - but I'm not sure the developers haven't decided that Views is the favoured solution?].

[Re: 6.x: I can't contemplate 6.x for production sites. I'm still struggling with porting one complicated 4.7 site to 5.x. As a time-and-ability-limited user, not a developer, I'm afraid the pace of Drupal development and exploding complexity outstrips my ability to keep up. Mind you, looking at the issue queue for 6.x Image (+ Views in particular) it seems to outrun even the developers... ;) ]

The patched version discussed here uses taxonomy for galleries too. It just does it properly, ie can handle images that have multiple taxonomy terms without breaking breadcrumbs when using next|prev links. The original code just uses the first term for the gallery which may or may not be the right one, if there are several, so clicking on a 'next' link can dump you at the correct image now in a different gallery.

I believe Nodeorder may become part of core in Drupal 7, though I can't now remember where I read that and haven't been able to find it again.