I got php notices when running this module and have attached a patch to fix them. I'm not sure about removing "session_start()". Perhaps that is only necessary for anonymous users in which case it could be wrapped in a "global $user; if (!$user->uid){ }" kind of logic.

To see the notices you will need to enable full error reporting. One way to do that is just to use a Drupal-6.x-dev tarball.

CommentFileSizeAuthor
notices_textsize.patch1.3 KBgreggles

Comments

CZ’s picture

CZ commented
Status: Needs review » Fixed

Fixed in the 6.x-1.0 release.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Fixed » Needs review

Thanks!

I was trying to review the changes. I don't see the return $ouput; fix. Nor is the $output variable initialized earlier in the file. I think it could use some more help.

CZ’s picture

CZ commented
Status: Needs review » Fixed

Yes, sorry. But now.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Thanks, it would also be nice for your commit messages to follow the standard format: http://drupal.org/node/52287

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.