Posted by greggles on October 9, 2008 at 4:42pm
Jump to:
| Project: | Text Size |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I got php notices when running this module and have attached a patch to fix them. I'm not sure about removing "session_start()". Perhaps that is only necessary for anonymous users in which case it could be wrapped in a "global $user; if (!$user->uid){ }" kind of logic.
To see the notices you will need to enable full error reporting. One way to do that is just to use a Drupal-6.x-dev tarball.
| Attachment | Size |
|---|---|
| notices_textsize.patch | 1.3 KB |
Comments
#1
Fixed in the 6.x-1.0 release.
#2
Thanks!
I was trying to review the changes. I don't see the
return $ouput;fix. Nor is the $output variable initialized earlier in the file. I think it could use some more help.#3
Yes, sorry. But now.
#4
Thanks, it would also be nice for your commit messages to follow the standard format: http://drupal.org/node/52287
#5
Automatically closed -- issue fixed for 2 weeks with no activity.