The drupal forms API seems like a cleaner way of creating image nodes than the current code. In particular
* the uploaded images will have to obey the constraints on image size set by in the image module admin
* _image_build_derivatives() doesn't have to be called (this is not an image module api function anyway)
* the settings for comments etc. used by image module will automatically be used
The attached patch replaces the current code with a form which is then submitted via drupal_execute().
I've tested it, and it appears to work. I'll wait for a week or two for comments. If I don't hear anything, I'll apply it.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 20081114-image_add.patch | 4.02 KB | egfrith |
| 20081018-image_add.patch | 3.2 KB | egfrith |
Comments
Comment #1
egfrith commentedComment #2
egfrith commentedThis should fix #288251: Subscription email messages not being sent when using Image Publishing.
Comment #3
egfrith commentedI've fixed one or two errors in the previous patch, and have applied the attached patch.