Hi... I've installed ACIDFREE on my DRUPAL-Testsystem and I found the following bug:

The MASS-import will not function correctly if you have installed an other language than "English". The Language on my site is "German" and the buttons in the upload-form have other values than "Import" and "Upload". In the german version they are called "Hochladen" and "Importieren" and I think in other languages they will have other values too ;-).

The function "_acidfree_import_form" in "acidfree.modules" calls the value of $_POST['import'] and checks the value of this variable against the values inside the switch of the function to determine what to do. Because the values are not "import" or "upload" nothing happens after sending the files.

Because I'm a Drupalnewbie I have currently no clue how to change this correctly. Maybe you can get the values for these buttons from the language file or something, because they must be available somewhere. I will look throught it again and maybe I can find a fix for this.

When I switch to the english version the import will function like a charm. As a workaround for problem I have also put the values of the german buttons to this function...

CommentFileSizeAuthor
#3 mass_import_other_lang.patch797 bytesvhmauery

Comments

aalex’s picture

aalex commented

Same thing here. But I haven't yet installed the French language on my local test site. I get the following error when I try to mass import a directory (whereas the directory I try to import DOES exist) :

warning: fopen(private/filemanager.lck): failed to open stream: No such file or directory in /Library/Apache2/htdocs/drupal-4.6.2/modules/filemanager/filemanager.module on line 169.

TomMynd’s picture

TomMynd commented

I thing that this is another problem and has nothing to do with the problem that I have encountered.

Did you patched the filemanager module??

There is a comment on line 169 in the patched version (patch comes with the acidfree module). On line 169 in the original version of the filemanager.module there is the command to open the lock-file. So this must be the problem on your side.

From the file "filemanager-acidfree.patch"

NOTE: this patch MUST be applied to the filemanager source
or acidfree will not work correctly.  To apply, do something like this:

cd modules/filemanager
patch -p0 < path/to/this/patch/filemanager-acidfree.patch

This will be all you have to do, to make it work.

vhmauery’s picture

vhmauery commented
Status: Active » Needs review
StatusFileSize
new mass_import_other_lang.patch797 bytes

Here is a patch that should fix the first problem listed in this bug. When the form was submitted, I forgot to compare the values of the submit button to translated strings, even though I had the button values translated themselves. (btw, I am new to the i18n stuff, so I can use all the help and pointers you have). Try out this patch and let me know if it fixes the problem.

vhmauery’s picture

vhmauery commented

As for the issues listed in comment #1, the fopen(private/filemanager.lck) problem is caused by not having filemanager set up correctly. It needs both the public and private paths to exist and be writeable by the webserver. (in my case, the user www-data). So go to admin/settings/filemanager and make sure "Public file system path:" and "Private file system path:" are sane values and web-writable.

vhmauery’s picture

vhmauery commented
Status: Needs review » Fixed

Since nobody has updated this bug, I am marking it as fixed. The fix in in the latest CVS version for both HEAD and 4.6 branches. Or you can apply the patch. If that doesn't work, please update the bug.

vhmauery’s picture

vhmauery commented
Status: Fixed » Closed (fixed)