Posted by lonecat on October 22, 2008 at 5:10pm
| Project: | Language icons |
| Version: | 6.x-2.x-dev |
| Component: | Icon collection |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The icon is in the attachement file, and it's name should be zh-hans.png.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| zh-hans.png | 354 bytes | Ignored: Check issue status. | None | None |
Comments
#1
Should this, the flag/icon, be different from zh-hant (traditional Chinese), or could I copy this icon to zh-hant.png and check both in?
#2
Traditional Chinese is commonly used in Taiwan, Hong Kong and Macau.
There are some slight differences in usage in each place, so e.g. Chinese Wikipedia actually include functionality to differentiate between zh-tw and zh-hk (ditto for zh-cn and zh-sg for simplified Chinese); but most sites just use zh-hant with the Taiwanese flag and ignore the difference.
I have attached a 16x12 RoC flag rendered from http://en.wikipedia.org/wiki/Image:Flag_of_the_Republic_of_China.svg . This can be used for zh-hant.
I have also attached a 16x12 PRoC flag rendered from
http://en.wikipedia.org/wiki/Image:Flag_of_the_People%27s_Republic_of_Ch... and reworked a little to improve the contrast over the one from lonecat. This can be used for zh-hans.
These are retrieved on 10 Dec 2008 and are in the public domain, so it should be no problem to include them.
#3
1. I see Bulgarian flag is missing too. Attached it. (17x12 px)
2. I counted only 42 flags in the default flags dir of the module - diffed dev and stable they are identical.
3. Furthermore some of the flags there have slightly different dimensions ...
So we need a better default icon set (I saw we are in the process of implementing an icon set chooser).... Firstly I need to know has someone worked on that (a perfect default icon set) - please share with us so we can help...
Otherwise I would:
- normalize the dimensions - should be 16x12 - as written in the project page, right?
- then just take the official flags of all countries in the world and render them - some from wikipedia - some from elsewhere if needed - but I believe that WP has them all - maybe in an article esp about the flags...
There should not be a problem with licensing ... from where is the current set taken?
And what is the standart defining file names - ISO what version?
#4
@ dev13: Excellent. I ran your icons through pngcrush and cut off some extra bytes and then uploaded them to 6.x-2.x and 6.x-1.x. Thank you for the icons and explanations. :D
@ rsvelko:
1. Please open a new issue for a new issue (ie., adding a flag) rather than add to an existing issue. This one's no biggie, but it would just be preferable. Thank you. :)
2. They should be. 6.x-2.x hasn't really gotten any isolated development since it broke off from -1.x. The two main features of -2.x will be #319966: Add flag icon theme selector and #310859: Various string issues. I would be very thankful if you would help either of those proceed. :)
3. That is intentional; see #362583: Flag ratios. I guess I should update the project page.
"Just" taking the official flags from all countries is easier said than done. First of all, there are a lot of countries and hundreds more languages - sometimes it makes more sense to use a regional flag (e.g. it makes more sense to use the flag of Scotland for the Scots and Scots Gaelic languages, than it would to use the Union Jack). Second, some languages are spoken in more than one country, and some countries have more than one official (and native) language. All of this makes it hard to do anything automatically, which means manual labour has to be put into every added flag. Which means they're not added, unless someone requests them. :)
The current set is partly from the old days where it was a part of the Internationalization module suite and partly mine (and others') rips from Public Domain SVG-flags off Wikipedia.
The file names should correspond to the codes used by Drupal, which, per D6, are defined by BCP 47 (which is explained in (more) human language in this W3C article).
Oh, and I've added a Bulgarian flag with proper ratio (pulled from Wikipedia) to 6.x-1.x and 6.x-2.x. Thanks for the help. :)
#5
Automatically closed -- issue fixed for 2 weeks with no activity.